soc/amd/picasso/soc_util: add TODO to Dali detection

Change-Id: I8ff5a9275d4cdf0049b63cc30b8a1cc376b50f80
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40321
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Felix Held 2020-04-12 02:17:44 +02:00 committed by Felix Held
parent da968d5f2e
commit a67c753d55
1 changed files with 4 additions and 0 deletions

View File

@ -10,6 +10,10 @@ int soc_is_pollock(void)
return soc_is_zen_plus() && CONFIG(AMD_FT5);
}
/*
* TODO: This detection works for the Dali SKUs used in Chrome-devices, but fails for other
* Dali SKUs, since other Dali SKUs have a Zen+ CPUID and not a Raven2 one.
*/
int soc_is_dali(void)
{
return soc_is_raven2() && CONFIG(AMD_FP5);