GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/brya: Add Kconfig for SLP_S0_GATE 

Nissa doesn't have a SLP_S0_GATE signal, so we shouldn't generate the
related ACPI code. Therefore, move this behind a Kconfig which is
currently selected by the brya and brask baseboards.

BUG=b:197479026
TEST=Build brya0, check that there's no change to the generated dsdt.asl

Change-Id: I5a73c6794f6d3977cbff47aeff571154e41944cc
Signed-off-by: Reka Norman <rekanorman@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61347
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
This commit is contained in:
Reka Norman 2022-01-25 10:07:42 +11:00 committed by Felix Held
parent 880f70660d
commit a69125c723
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/mainboard/google/brya/Kconfig
View File

@ -39,6 +39,7 @@ config BOARD_GOOGLE_BRYA_COMMON
config BOARD_GOOGLE_BASEBOARD_BRYA config BOARD_GOOGLE_BASEBOARD_BRYA
def_bool n def_bool n
select BOARD_GOOGLE_BRYA_COMMON select BOARD_GOOGLE_BRYA_COMMON
select HAVE_SLP_S0_GATE
select MEMORY_SOLDERDOWN if !BOARD_GOOGLE_BANSHEE select MEMORY_SOLDERDOWN if !BOARD_GOOGLE_BANSHEE
select SOC_INTEL_ALDERLAKE_PCH_P select SOC_INTEL_ALDERLAKE_PCH_P
select SYSTEM_TYPE_LAPTOP select SYSTEM_TYPE_LAPTOP
@ -47,6 +48,7 @@ config BOARD_GOOGLE_BASEBOARD_BRASK
def_bool n def_bool n
select BOARD_GOOGLE_BRYA_COMMON select BOARD_GOOGLE_BRYA_COMMON
select ENABLE_TCSS_DISPLAY_DETECTION if RUN_FSP_GOP select ENABLE_TCSS_DISPLAY_DETECTION if RUN_FSP_GOP
select HAVE_SLP_S0_GATE
select MEMORY_SODIMM select MEMORY_SODIMM
select RT8168_GEN_ACPI_POWER_RESOURCE select RT8168_GEN_ACPI_POWER_RESOURCE
select RT8168_GET_MAC_FROM_VPD select RT8168_GET_MAC_FROM_VPD
@ -227,4 +229,7 @@ config MEMORY_SOLDERDOWN
select CHROMEOS_DRAM_PART_NUMBER_IN_CBI if CHROMEOS select CHROMEOS_DRAM_PART_NUMBER_IN_CBI if CHROMEOS
select HAVE_SPD_IN_CBFS select HAVE_SPD_IN_CBFS
config HAVE_SLP_S0_GATE
def_bool n
endif # BOARD_GOOGLE_BRYA_COMMON endif # BOARD_GOOGLE_BRYA_COMMON

2
src/mainboard/google/brya/mainboard.asl
View File

@ -2,6 +2,7 @@
#include <baseboard/gpio.h> #include <baseboard/gpio.h>
#if CONFIG(HAVE_SLP_S0_GATE)
/* /*
* S0ix Entry/Exit Notifications * S0ix Entry/Exit Notifications
* Called from \_SB.PEPD._DSM * Called from \_SB.PEPD._DSM
@ -22,3 +23,4 @@ Method (MS0X, 1, Serialized)
\_SB.PCI0.STXS(GPIO_SLP_S0_GATE); \_SB.PCI0.STXS(GPIO_SLP_S0_GATE);
} }
} }
#endif