GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/brya: Restructure PMC descriptor update 

Restructure the code in the `configure_pmc_descriptor()` so that it
matches the code for the `intel/adlrvp` mainboard. This change does
not reindent the contents of the original if-block intentionally as
this will be taken care of in a reproducible follow-up.

Change-Id: I8c9d9087cb2d0668f6a4afbb566d830bb9febd89
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/60937
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Subrata Banik <subratabanik@google.com>
Reviewed-by: Sheng Lean Tan <sheng.tan@9elements.com>
This commit is contained in:
Angel Pons 2022-01-08 12:41:51 +01:00 committed by Felix Held
parent 9a91ed3370
commit a6bc494e23
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/mainboard/google/brya/bootblock.c
View File

@ -29,7 +29,12 @@ static void configure_pmc_descriptor(void)
return;
}
if (si_desc_buf[PMC_DESC_7_BYTE3] == 0x40) {
if (si_desc_buf[PMC_DESC_7_BYTE3] != 0x40) {
printk(BIOS_DEBUG, "Update of PMC Descriptor is not required!\n");
return;
}
{
si_desc_buf[PMC_DESC_7_BYTE3] = 0x44;
if (rdev_eraseat(&desc_rdev, 0, SI_DESC_REGION_SZ) != SI_DESC_REGION_SZ) {
@ -49,8 +54,6 @@ static void configure_pmc_descriptor(void)
do_full_reset();
die("Failed to trigger GLOBAL RESET\n");
}
printk(BIOS_DEBUG, "Update of PMC Descriptor is not required!\n");
}
void bootblock_mainboard_early_init(void)