From a6df40ca436142d84e6ffc34246f543c1bcd19c2 Mon Sep 17 00:00:00 2001 From: Ziang Wang Date: Mon, 29 May 2023 15:53:56 +0800 Subject: [PATCH] device/dram: Update RDIMM classification from RIMM to DIMM Registered DIMM should be 'FORMFACTOR_DIMM' with 'DETAIL_REGISTERED' instead of 'FORMFACTOR_RIMM', RIMM has been EOL for so many years. Memory form factor info is now correct on 4th Gen Xeon server platform with registered DIMM. Signed-off-by: Ziang Wang Signed-off-by: Kehong Chen Change-Id: I1eea4717a2d60c6100c262a2284a2ac5109f114a Reviewed-on: https://review.coreboot.org/c/coreboot/+/75489 Tested-by: build bot (Jenkins) Reviewed-by: Lean Sheng Tan Reviewed-by: Felix Singer --- src/device/dram/spd.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/device/dram/spd.c b/src/device/dram/spd.c index 564a4ead92..4a1e882543 100644 --- a/src/device/dram/spd.c +++ b/src/device/dram/spd.c @@ -57,7 +57,7 @@ static void convert_ddr2_module_type_to_spd_info(enum spd_dimm_type_ddr2 module_ switch (module_type) { case SPD_DDR2_DIMM_TYPE_RDIMM: case SPD_DDR2_DIMM_TYPE_MINI_RDIMM: - info->form_factor = MEMORY_FORMFACTOR_RIMM; + info->form_factor = MEMORY_FORMFACTOR_DIMM; info->type_detail = MEMORY_TYPE_DETAIL_REGISTERED; break; case SPD_DDR2_DIMM_TYPE_UDIMM: @@ -85,7 +85,7 @@ static void convert_ddr3_module_type_to_spd_info(enum spd_dimm_type_ddr3 module_ switch (module_type) { case SPD_DDR3_DIMM_TYPE_RDIMM: case SPD_DDR3_DIMM_TYPE_MINI_RDIMM: - info->form_factor = MEMORY_FORMFACTOR_RIMM; + info->form_factor = MEMORY_FORMFACTOR_DIMM; info->type_detail = MEMORY_TYPE_DETAIL_REGISTERED; break; case SPD_DDR3_DIMM_TYPE_UDIMM: @@ -114,7 +114,7 @@ static void convert_ddr4_module_type_to_spd_info(enum ddr4_module_type module_ty switch (module_type) { case DDR4_SPD_RDIMM: case DDR4_SPD_MINI_RDIMM: - info->form_factor = MEMORY_FORMFACTOR_RIMM; + info->form_factor = MEMORY_FORMFACTOR_DIMM; info->type_detail = MEMORY_TYPE_DETAIL_REGISTERED; break; case DDR4_SPD_UDIMM: @@ -139,7 +139,7 @@ static void convert_ddr5_module_type_to_spd_info(enum ddr5_module_type module_ty switch (module_type) { case DDR5_SPD_RDIMM: case DDR5_SPD_MINI_RDIMM: - info->form_factor = MEMORY_FORMFACTOR_RIMM; + info->form_factor = MEMORY_FORMFACTOR_DIMM; info->type_detail = MEMORY_TYPE_DETAIL_REGISTERED; break; case DDR5_SPD_UDIMM: