GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/common/block/include/gpio_defs: de-duplicate pin status bit defs 

De-duplicate the definitions for the pin status bit and use this new
definition in both the C and the ACPI code.

TEST=Timeless build results in identical image for amd/mandolin.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I8b0fe7dbec5dac176cdfa9690862433f202fb552
Reviewed-on: https://review.coreboot.org/c/coreboot/+/59595
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
This commit is contained in:
Felix Held 2021-11-23 10:19:28 +01:00
parent baa72db1b2
commit a7190ef2ec
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/soc/amd/common/acpi/gpio_bank_lib.asl
View File

@ -159,7 +159,7 @@ Method (GRXS, 1, Serialized)
{
VAL0, 32
}
Local0 = (GPIO_INPUT_VALUE & VAL0) >> GPIO_INPUT_SHIFT
Local0 = (GPIO_PIN_STS & VAL0) >> GPIO_PIN_STS_SHIFT
Return (Local0)
}

6
src/soc/amd/common/block/include/amdblocks/gpio_defs.h
View File

@ -54,15 +54,13 @@
#define GPIO_WAKE_S3_S4_S5 (GPIO_WAKE_S3 | GPIO_WAKE_S4_S5)
#define GPIO_WAKE_MASK (GPIO_WAKE_S0i3 | GPIO_WAKE_S3 | GPIO_WAKE_S4_S5)
#define GPIO_PIN_STS (1 << 16)
#define GPIO_PIN_STS_SHIFT 16
#define GPIO_PIN_STS (1 << GPIO_PIN_STS_SHIFT)
#define GPIO_PULLUP_ENABLE (1 << 20)
#define GPIO_PULLDOWN_ENABLE (1 << 21)
#define GPIO_PULL_MASK (GPIO_PULLUP_ENABLE | GPIO_PULLDOWN_ENABLE)
#define GPIO_INPUT_SHIFT 16
#define GPIO_INPUT_VALUE (1 << GPIO_INPUT_SHIFT)
#define GPIO_OUTPUT_SHIFT 22
#define GPIO_OUTPUT_VALUE (1 << GPIO_OUTPUT_SHIFT)
#define GPIO_OUTPUT_ENABLE (1 << 23)