GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/common/block/graphics: Don't add VBIOS to cbmem when using GOP 

pci_rom_ssdt reloads the oprom from cbfs. It then places it into cbmem
and writes the offsets as the ROM ACPI node. The GOP driver modifies the
VBIOS so we don't want to reread from cbfs. When using GOP we also pass
the offsets with the VFCT table.

Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Change-Id: Iaf53e750564f1f0e115cd354790da62e672d74b7
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51541
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nikolai Vyssotski <nikolai.vyssotski@amd.corp-partner.google.com>
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Raul E Rangel 2021-03-16 13:20:23 -06:00 committed by Martin Roth
parent 3920bc9626
commit a7659ebe4e
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/soc/amd/common/block/graphics/graphics.c
View File

@ -108,7 +108,11 @@ static void generate_atif(const struct device *dev)
static void graphics_fill_ssdt(const struct device *dev) static void graphics_fill_ssdt(const struct device *dev)
{ {
acpi_device_write_pci_dev(dev); acpi_device_write_pci_dev(dev);
pci_rom_ssdt(dev);
/* Use the VFCT copy when using GOP */
if (!CONFIG(RUN_FSP_GOP))
pci_rom_ssdt(dev);
if (CONFIG(SOC_AMD_COMMON_BLOCK_GRAPHICS_ATIF)) if (CONFIG(SOC_AMD_COMMON_BLOCK_GRAPHICS_ATIF))
generate_atif(dev); generate_atif(dev);
} }