GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

device: Give `pci_ops.set_L1_ss_latency` a proper name 

Rename `set_L1_ss_latency` to what it does: `set_ltr_max_latencies`.

TEST=Built google/brya0 with BUILD_TIMELESS=1: no changes.

Change-Id: I7008aa18bf80d6709dce1b2d3bfbb5ea407a0574
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51326
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Nico Huber 2021-03-06 14:13:58 +01:00
parent 2d24146aef
commit a768deae73
4 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/device/pciexp_device.c
View File

@ -132,8 +132,8 @@ static void pciexp_config_max_latency(struct device *root, struct device *dev)
unsigned int cap; unsigned int cap;
cap = pciexp_find_extended_cap(dev, PCIE_EXT_CAP_LTR_ID); cap = pciexp_find_extended_cap(dev, PCIE_EXT_CAP_LTR_ID);
if ((cap) && (root->ops->ops_pci != NULL) && if ((cap) && (root->ops->ops_pci != NULL) &&
(root->ops->ops_pci->set_L1_ss_latency != NULL)) (root->ops->ops_pci->set_ltr_max_latencies != NULL))
root->ops->ops_pci->set_L1_ss_latency(dev, cap + 4); root->ops->ops_pci->set_ltr_max_latencies(dev, cap + 4);
} }
static bool pciexp_is_ltr_supported(struct device *dev, unsigned int cap) static bool pciexp_is_ltr_supported(struct device *dev, unsigned int cap)

2
src/include/device/pci.h
View File

@ -31,7 +31,7 @@ struct pci_operations {
/* set the Subsystem IDs for the PCI device */ /* set the Subsystem IDs for the PCI device */
void (*set_subsystem)(struct device *dev, unsigned int vendor, void (*set_subsystem)(struct device *dev, unsigned int vendor,
unsigned int device); unsigned int device);
void (*set_L1_ss_latency)(struct device *dev, unsigned int off); void (*set_ltr_max_latencies)(struct device *dev, unsigned int off);
}; };
struct pci_driver { struct pci_driver {

4
src/soc/intel/broadwell/pch/pcie.c
View File

@ -609,7 +609,7 @@ static void pch_pcie_enable(struct device *dev)
root_port_commit_config(); root_port_commit_config();
} }
static void pcie_set_L1_ss_max_latency(struct device *dev, unsigned int off) static void pcie_set_ltr_max_latencies(struct device *dev, unsigned int off)
{ {
/* Set max snoop and non-snoop latency for Broadwell */ /* Set max snoop and non-snoop latency for Broadwell */
pci_write_config32(dev, off, pci_write_config32(dev, off,
@ -619,7 +619,7 @@ static void pcie_set_L1_ss_max_latency(struct device *dev, unsigned int off)
static struct pci_operations pcie_ops = { static struct pci_operations pcie_ops = {
.set_subsystem = pci_dev_set_subsystem, .set_subsystem = pci_dev_set_subsystem,
.set_L1_ss_latency = pcie_set_L1_ss_max_latency, .set_ltr_max_latencies = pcie_set_ltr_max_latencies,
}; };
static struct device_operations device_ops = { static struct device_operations device_ops = {

4
src/soc/intel/common/block/pcie/pcie.c
View File

@ -45,7 +45,7 @@ static void pch_pcie_init(struct device *dev)
pci_write_config16(dev, PCI_SEC_STATUS, reg16); pci_write_config16(dev, PCI_SEC_STATUS, reg16);
} }
static void pcie_set_L1_ss_max_latency(struct device *dev, unsigned int offset) static void pcie_set_ltr_max_latencies(struct device *dev, unsigned int offset)
{ {
/* Set max snoop and non-snoop latency for the SOC */ /* Set max snoop and non-snoop latency for the SOC */
pci_write_config32(dev, offset, pci_write_config32(dev, offset,
@ -54,7 +54,7 @@ static void pcie_set_L1_ss_max_latency(struct device *dev, unsigned int offset)
} }
static struct pci_operations pcie_ops = { static struct pci_operations pcie_ops = {
.set_L1_ss_latency = pcie_set_L1_ss_max_latency, .set_ltr_max_latencies = pcie_set_ltr_max_latencies,
.set_subsystem = pci_dev_set_subsystem, .set_subsystem = pci_dev_set_subsystem,
}; };