GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/lenovo/*/acpi_tables: Don't initialize already initialized fields 

Don't initialize fields with zeroes since gnvs structs were zeroed out
in southbridge already.

Change-Id: I2ccf4699ba3ed3f5b9402c0340153d4a5bf82682
Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37938
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
This commit is contained in:
Peter Lemenkov 2019-12-26 21:17:33 +03:00 committed by Patrick Rudolph
parent 0acfe1c8cd
commit a76cf28279
13 changed files with 0 additions and 109 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/mainboard/lenovo/l520/acpi_tables.c
View File

@ -21,14 +21,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs) void acpi_create_gnvs(global_nvs_t *gnvs)
{ {
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
// the lid is open by default. // the lid is open by default.
gnvs->lids = 1; gnvs->lids = 1;

8
src/mainboard/lenovo/s230u/acpi_tables.c
View File

@ -18,14 +18,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs) void acpi_create_gnvs(global_nvs_t *gnvs)
{ {
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
/* The LID is open by default */ /* The LID is open by default */
gnvs->lids = 1; gnvs->lids = 1;

8
src/mainboard/lenovo/t420/acpi_tables.c
View File

@ -18,14 +18,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs) void acpi_create_gnvs(global_nvs_t *gnvs)
{ {
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
// the lid is open by default. // the lid is open by default.
gnvs->lids = 1; gnvs->lids = 1;

8
src/mainboard/lenovo/t420s/acpi_tables.c
View File

@ -18,14 +18,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs) void acpi_create_gnvs(global_nvs_t *gnvs)
{ {
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
// the lid is open by default. // the lid is open by default.
gnvs->lids = 1; gnvs->lids = 1;

13
src/mainboard/lenovo/t430/acpi_tables.c
View File

@ -18,22 +18,9 @@
void acpi_create_gnvs(global_nvs_t *gnvs) void acpi_create_gnvs(global_nvs_t *gnvs)
{ {
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
// the lid is open by default. // the lid is open by default.
gnvs->lids = 1; gnvs->lids = 1;
gnvs->tmps = CTDP_SENSOR_ID;
gnvs->f1of = CTDP_NOMINAL_THRESHOLD_OFF;
gnvs->f1on = CTDP_NOMINAL_THRESHOLD_ON;
gnvs->f0of = CTDP_DOWN_THRESHOLD_OFF; gnvs->f0of = CTDP_DOWN_THRESHOLD_OFF;
gnvs->f0on = CTDP_DOWN_THRESHOLD_ON; gnvs->f0on = CTDP_DOWN_THRESHOLD_ON;

8
src/mainboard/lenovo/t430s/acpi_tables.c
View File

@ -18,14 +18,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs) void acpi_create_gnvs(global_nvs_t *gnvs)
{ {
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
// the lid is open by default. // the lid is open by default.
gnvs->lids = 1; gnvs->lids = 1;

8
src/mainboard/lenovo/t440p/acpi_tables.c
View File

@ -19,14 +19,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs) void acpi_create_gnvs(global_nvs_t *gnvs)
{ {
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
/* the lid is open by default */ /* the lid is open by default */
gnvs->lids = 1; gnvs->lids = 1;

8
src/mainboard/lenovo/t520/acpi_tables.c
View File

@ -18,14 +18,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs) void acpi_create_gnvs(global_nvs_t *gnvs)
{ {
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
// the lid is open by default. // the lid is open by default.
gnvs->lids = 1; gnvs->lids = 1;

8
src/mainboard/lenovo/t530/acpi_tables.c
View File

@ -18,14 +18,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs) void acpi_create_gnvs(global_nvs_t *gnvs)
{ {
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
// the lid is open by default. // the lid is open by default.
gnvs->lids = 1; gnvs->lids = 1;

8
src/mainboard/lenovo/x131e/acpi_tables.c
View File

@ -18,14 +18,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs) void acpi_create_gnvs(global_nvs_t *gnvs)
{ {
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
// the lid is open by default. // the lid is open by default.
gnvs->lids = 1; gnvs->lids = 1;

8
src/mainboard/lenovo/x1_carbon_gen1/acpi_tables.c
View File

@ -18,14 +18,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs) void acpi_create_gnvs(global_nvs_t *gnvs)
{ {
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
// the lid is open by default. // the lid is open by default.
gnvs->lids = 1; gnvs->lids = 1;

8
src/mainboard/lenovo/x220/acpi_tables.c
View File

@ -18,14 +18,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs) void acpi_create_gnvs(global_nvs_t *gnvs)
{ {
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
// the lid is open by default. // the lid is open by default.
gnvs->lids = 1; gnvs->lids = 1;

8
src/mainboard/lenovo/x230/acpi_tables.c
View File

@ -18,14 +18,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs) void acpi_create_gnvs(global_nvs_t *gnvs)
{ {
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
// the lid is open by default. // the lid is open by default.
gnvs->lids = 1; gnvs->lids = 1;