GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/picasso/data_fabric: make register number parameter unsigned 

The register number is always non-negative, so it should be an unsigned
type.

Change-Id: I6b6df5a41fe58efc53eaa87c01b88426ea8daa6e
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45430
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
Felix Held 2020-09-15 16:21:46 +02:00
parent bf90b14d6a
commit a79e01bf71
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/soc/amd/picasso/data_fabric.c
View File

@ -12,7 +12,7 @@
#include <soc/pci_devs.h> #include <soc/pci_devs.h>
#include <types.h> #include <types.h>
static void disable_mmio_reg(int reg) static void disable_mmio_reg(unsigned int reg)
{ {
pci_write_config32(SOC_DF_F0_DEV, NB_MMIO_CONTROL(reg), pci_write_config32(SOC_DF_F0_DEV, NB_MMIO_CONTROL(reg),
IOMS0_FABRIC_ID << MMIO_DST_FABRIC_ID_SHIFT); IOMS0_FABRIC_ID << MMIO_DST_FABRIC_ID_SHIFT);
@ -20,7 +20,7 @@ static void disable_mmio_reg(int reg)
pci_write_config32(SOC_DF_F0_DEV, NB_MMIO_LIMIT(reg), 0); pci_write_config32(SOC_DF_F0_DEV, NB_MMIO_LIMIT(reg), 0);
} }
static bool is_mmio_reg_disabled(int reg) static bool is_mmio_reg_disabled(unsigned int reg)
{ {
uint32_t val = pci_read_config32(SOC_DF_F0_DEV, NB_MMIO_CONTROL(reg)); uint32_t val = pci_read_config32(SOC_DF_F0_DEV, NB_MMIO_CONTROL(reg));
return !(val & ((MMIO_WE | MMIO_RE))); return !(val & ((MMIO_WE | MMIO_RE)));