GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/skylake: Clean up SoC ASL code. 

List of changes done here in this patch

1. Remove CARD definition from EMMC and SD Card Controller in scs.asl
since _RMV method does not get evaluated while setting up removable
attribute in sysfs in kernel.
"cat /sys/block/mmcblk1/removable" this command always returns 0.

This CARD Device includes _ADR which follows SDIO Bus format. But,
SD/EMMC sits on PCI Bus.
Hence this CARD Device specific _ADR code is also not needed.

2. Remove Base Address for ACPI debug output memory buffer in
systemagent.asl as it is not getting used throughout the code.

BUG=none
BRANCH=none
TEST=Build and boot kunimitsu

Change-Id: I29effaffdafcc21e26445ec3c54aedecdbc50274
Signed-off-by: Barnali Sarkar <barnali.sarkar@intel.com>
Reviewed-on: https://review.coreboot.org/16068
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Reviewed-by: Subrata Banik <subrata.banik@intel.com>
This commit is contained in:
Barnali Sarkar 2016-08-04 17:46:55 +05:30 committed by Martin Roth
parent 8f2f22d258
commit a7b97510ae
2 changed files with 0 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/soc/intel/skylake/acpi/scs.asl
View File

@ -59,15 +59,6 @@ Device (EMMC)
Store (Local0, ^D0D3) Store (Local0, ^D0D3)
Store (^D0D3, Local0) Store (^D0D3, Local0)
} }
Device (CARD)
{
Name (_ADR, 0x00000008)
Method (_RMV, 0, NotSerialized)
{
Return (0)
}
}
} }
#if !IS_ENABLED(CONFIG_EXCLUDE_NATIVE_SD_INTERFACE) #if !IS_ENABLED(CONFIG_EXCLUDE_NATIVE_SD_INTERFACE)
@ -130,14 +121,5 @@ Device (SDXC)
^^PCRO (PID_GPIOCOM3, 0x4e4, 0x00001000) ^^PCRO (PID_GPIOCOM3, 0x4e4, 0x00001000)
^^PCRO (PID_GPIOCOM3, 0x4f4, 0x00001000) ^^PCRO (PID_GPIOCOM3, 0x4f4, 0x00001000)
} }
Device (CARD)
{
Name (_ADR, 0x00000008)
Method (_RMV, 0, NotSerialized)
{
Return (1)
}
}
} }
#endif #endif

5
src/soc/intel/skylake/acpi/systemagent.asl
View File

@ -340,11 +340,6 @@ Device (PDRC)
/* HPET address decode range */ /* HPET address decode range */
Memory32Fixed (ReadWrite, HPET_BASE_ADDRESS, 0x400) Memory32Fixed (ReadWrite, HPET_BASE_ADDRESS, 0x400)
/* Debug Base Address
* Base Address for ACPI debug output memory buffer
*/
Memory32Fixed (ReadWrite, 0, 0, DBAD)
}) })
Method (_CRS, 0, Serialized) Method (_CRS, 0, Serialized)