GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

inteltool: Use `ll` instead of `l` as the length modifier for `uint64_t` 

When buidling inteltool with GCC, the following warning is printed.

    $ make
    […]
    gcc -O2 -g -Wall -W   -c -o memory.o memory.c
    memory.c: In function ‘print_mchbar’:
    memory.c:287:7: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘uint64_t’ [-Wformat]
    […]

This was introduced in commit »inteltool: Add support for H65 Express
chipset« (c7fc4422) [1].

Address this warning, by using `%llx` instead of `%lx`.

[1] http://review.coreboot.org/1258

Change-Id: I4f714edce7e8b405e1a7a417d02fa498322c88a8
Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-on: http://review.coreboot.org/2994
Reviewed-by: Anton Kochkov <anton.kochkov@gmail.com>
Tested-by: build bot (Jenkins)
This commit is contained in:
Paul Menzel 2013-03-31 22:02:16 +02:00 committed by Anton Kochkov
parent aa3f7ba36e
commit a8db717d4a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
util/inteltool/memory.c
View File

@ -197,7 +197,7 @@ int print_mchbar(struct pci_dev *nb, struct pci_access *pacc)
for (i = 0; i < size; i++) { for (i = 0; i < size; i++) {
switch (mch_registers[i].size) { switch (mch_registers[i].size) {
case 8: case 8:
printf("mchbase+0x%04x: 0x%016lx (%s)\n", printf("mchbase+0x%04x: 0x%016llx (%s)\n",
mch_registers[i].addr, mch_registers[i].addr,
*(uint64_t *)(mchbar+mch_registers[i].addr), *(uint64_t *)(mchbar+mch_registers[i].addr),
mch_registers[i].name); mch_registers[i].name);