GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

write_tables: return a pointer to the table 

The write_tables function was void. It is a bit more
useful for loading payloads from the romstage
if it returns a pointer to the table it creates.

Change-Id: I6eeaf3e16bcbaf1e7ec3eada8026c466d2fb6f5a
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Reviewed-on: https://review.coreboot.org/27537
Reviewed-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Ronald G. Minnich 2018-07-18 14:35:01 -07:00
parent 4a6477ed64
commit a8fa25138b
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/include/boot/tables.h
View File

@ -6,8 +6,9 @@
/* /*
* Write architecture specific tables as well as the common * Write architecture specific tables as well as the common
* coreboot table. * coreboot table.
* Returns a pointer to the table or NULL on error.
*/ */
void write_tables(void); void *write_tables(void);
/* /*
* Allow per-architecture table writes called from write_tables(). The * Allow per-architecture table writes called from write_tables(). The

5
src/lib/coreboot_table.c
View File

@ -585,7 +585,7 @@ static uintptr_t write_coreboot_table(uintptr_t rom_table_end)
return lb_table_fini(head); return lb_table_fini(head);
} }
void write_tables(void) void *write_tables(void)
{ {
uintptr_t cbtable_start; uintptr_t cbtable_start;
uintptr_t cbtable_end; uintptr_t cbtable_end;
@ -596,7 +596,7 @@ void write_tables(void)
if (!cbtable_start) { if (!cbtable_start) {
printk(BIOS_ERR, "Could not add CBMEM for coreboot table.\n"); printk(BIOS_ERR, "Could not add CBMEM for coreboot table.\n");
return; return NULL;
} }
/* Add architecture specific tables. */ /* Add architecture specific tables. */
@ -615,4 +615,5 @@ void write_tables(void)
/* Print CBMEM sections */ /* Print CBMEM sections */
cbmem_list(); cbmem_list();
return (void *)cbtable_start;
} }