GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/common/blocks/lpc: Explicitly disable serial IRQ 

The serirq enable bit defaults to true, so if we want it disabled, we
need to explicitly disable it.

BUG=b:180631748
TEST=Boot majolica and see spurious IRQ 9 gone.

Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Change-Id: I7f1e18f836f29cb75334dd88c91ad047f5bdfb10
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51077
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
This commit is contained in:
Raul E Rangel 2021-02-24 16:26:34 -07:00 committed by Martin Roth
parent 3173f857b6
commit a91eb90d44
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/soc/amd/common/block/lpc/lpc.c
View File

@ -28,7 +28,9 @@ static void setup_serirq(void)
u8 byte; u8 byte;
/* Set up SERIRQ, enable continuous mode */ /* Set up SERIRQ, enable continuous mode */
byte = (PM_SERIRQ_NUM_BITS_21 | PM_SERIRQ_ENABLE); byte = PM_SERIRQ_NUM_BITS_21;
if (!CONFIG(SOC_AMD_COMMON_BLOCK_USE_ESPI))
byte |= PM_SERIRQ_ENABLE;
if (!CONFIG(SERIRQ_CONTINUOUS_MODE)) if (!CONFIG(SERIRQ_CONTINUOUS_MODE))
byte |= PM_SERIRQ_MODE; byte |= PM_SERIRQ_MODE;
@ -91,7 +93,6 @@ static void lpc_init(struct device *dev)
/* Initialize i8254 timers */ /* Initialize i8254 timers */
setup_i8254(); setup_i8254();
if (!CONFIG(SOC_AMD_COMMON_BLOCK_USE_ESPI))
setup_serirq(); setup_serirq();
} }