From a959f0ad7620e2e8b13b51c34f7397caf53e9a5f Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Fri, 7 Jul 2023 13:56:21 +0200 Subject: [PATCH] allocator_v4: Disable top-down allocation for EDK2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit EDK2 seems to have problems at least with the resource allocation for Intel's IGD. While the investigation is ongoing, disable top-down allocation by default if the payload is known to be EDK2. Change-Id: I771d8a3b74b54a043624843a00498225d1f509ad Signed-off-by: Nico Huber Ticket: https://ticket.coreboot.org/issues/499 Reviewed-on: https://review.coreboot.org/c/coreboot/+/76373 Reviewed-by: Michał Żygowski Tested-by: build bot (Jenkins) Reviewed-by: Sean Rhodes --- src/device/Kconfig | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/device/Kconfig b/src/device/Kconfig index 2d2c6fffa7..8c6c734ad9 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -994,12 +994,15 @@ config I2C_TRANSFER_TIMEOUT_US is aborted and an error returned. config RESOURCE_ALLOCATION_TOP_DOWN - def_bool y + bool "Allocate resources from top down" + default n if PAYLOAD_EDK2 + default y help Top-down allocation is required to place resources above 4G by default (i.e. even when there is still space below). On some platforms, it might make a difference because of conflicts with - undeclared resources. + undeclared resources. EDK2 is currently reported to also have + problems on some platforms, at least with Intel's IGD. config XHCI_UTILS def_bool n