GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vendorcode/google/chromeos: Correct VPD field for MAC passthrough 

The VPD field name is dock_passthrough, not dock_passthru. Fix it.

(I assume there is no length limit)

BUG=b:132689337
TEST=check that the feature can now be controlled by the associated
enterprise policy

Change-Id: Icc2b070313fde74447279cd6ccaa4e3eb6d119ee
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32839
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Simon Glass 2019-05-16 14:51:51 -06:00 committed by Duncan Laurie
parent 6eaa78144c
commit aa2157430f
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/vendorcode/google/chromeos/acpi/amac.asl
View File

@ -16,16 +16,17 @@
/* /*
* The Realtek r8152 driver in the Linux kernel supports a MAC address * The Realtek r8152 driver in the Linux kernel supports a MAC address
* passthru feature which can result in the dock ethernet port using the * dock pass-through feature which can result in the dock ethernet port
* same MAC address that is assigned to the internal NIC. This is done * using the same MAC address that is assigned to the internal NIC. This
* by calling an ACPI method at \_SB.AMAC() which returns a formatted * is done by calling an ACPI method at \_SB.AMAC() which returns a
* string (as a buffer) containing the MAC address for the dock to use. * formatted string (as a buffer) containing the MAC address for the
* dock to use.
* *
* The Linux kernel implementation can be found at * The Linux kernel implementation can be found at
* drivers/net/usb/r8152.c:vendor_mac_passthru_addr_read() * drivers/net/usb/r8152.c:vendor_mac_passthru_addr_read()
* *
* For Chrome OS, the policy which controls where the dock MAC address * For Chrome OS, the policy which controls where the dock MAC address
* comes from is written into RW_VPD property "dock_passthru": * comes from is written into RW_VPD property "dock_passthrough":
* *
* "dock_mac" or empty: Use MAC address from RO_VPD value "dock_mac" * "dock_mac" or empty: Use MAC address from RO_VPD value "dock_mac"
* "ethernet_mac0": Use MAC address from RO_VPD value "ethernet_mac0" * "ethernet_mac0": Use MAC address from RO_VPD value "ethernet_mac0"
@ -39,8 +40,8 @@ Scope (\_SB)
/* Format expected by the Linux kernel r8152 driver */ /* Format expected by the Linux kernel r8152 driver */
Name (MACA, "_AUXMAC_#XXXXXXXXXXXX#") Name (MACA, "_AUXMAC_#XXXXXXXXXXXX#")
/* Get "dock_passthru" value from RW_VPD */ /* Get "dock_passthrough" value from RW_VPD */
Local0 = \VPD.VPDF ("RW", "dock_passthru") Local0 = \VPD.VPDF ("RW", "dock_passthrough")
Local1 = Zero Local1 = Zero
Switch (ToString (Local0)) Switch (ToString (Local0))