GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

google/trogdor: Remove GPIO_AP_SUSPEND_L 

This pin has been removed from recent revisions (or at least moved to a
pin that's not controlled like a normal GPIO). It has also never been
used on older ones (I think?). The same GPIO is now used as a SKU ID
pin, so make sure we're not incorrectly configuring it as an output
(although sku_id() overrides that later anyway, but it's still
incorrect).

BUG=b:160754995

Signed-off-by: Julius Werner <jwerner@chromium.org>
Change-Id: I6e0d56e230d0bef172d7b78cc48263e9b6f059de
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43471
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Philip Chen <philipchen@google.com>
Reviewed-by: Bob Moragues <moragues@google.com>
Reviewed-by: EricR Lai <ericr_lai@compal.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Julius Werner 2020-07-14 18:29:19 -07:00
parent 9754f38e82
commit aa4c1d2b5b
2 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/mainboard/google/trogdor/board.h
View File

@ -9,7 +9,6 @@
#define GPIO_EC_IN_RW GPIO(118) #define GPIO_EC_IN_RW GPIO(118)
#define GPIO_AP_EC_INT GPIO(94) #define GPIO_AP_EC_INT GPIO(94)
#define GPIO_AP_SUSPEND GPIO(20)
#define GPIO_WP_STATE GPIO(42) #define GPIO_WP_STATE GPIO(42)
#define GPIO_H1_AP_INT (CONFIG(TROGDOR_REV0) ? GPIO(21) : GPIO(42)) #define GPIO_H1_AP_INT (CONFIG(TROGDOR_REV0) ? GPIO(21) : GPIO(42))
#define GPIO_SD_CD_L GPIO(69) #define GPIO_SD_CD_L GPIO(69)

1
src/mainboard/google/trogdor/chromeos.c
View File

@ -14,7 +14,6 @@ void setup_chromeos_gpios(void)
{ {
gpio_input_pullup(GPIO_EC_IN_RW); gpio_input_pullup(GPIO_EC_IN_RW);
gpio_input_pullup(GPIO_AP_EC_INT); gpio_input_pullup(GPIO_AP_EC_INT);
gpio_output(GPIO_AP_SUSPEND, 1);
gpio_input(GPIO_WP_STATE); gpio_input(GPIO_WP_STATE);
gpio_input_pullup(GPIO_SD_CD_L); gpio_input_pullup(GPIO_SD_CD_L);
gpio_input_irq(GPIO_H1_AP_INT, IRQ_TYPE_RISING_EDGE, GPIO_PULL_UP); gpio_input_irq(GPIO_H1_AP_INT, IRQ_TYPE_RISING_EDGE, GPIO_PULL_UP);