GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

device/pci: Declare pcidev_path_on_bus() 

It is recommended to never reference PCI busses
using a static number. There is exception with
OPROM execution, where we want to translate the
bus number captured from the actual IO operation
into a matching device node in the devicetree.

Change-Id: I733c645ac5581c000b4cd6cdc05829cd039324d5
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34077
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
Kyösti Mälkki 2019-07-04 07:16:59 +03:00 committed by Patrick Georgi
parent c19d6a6ce5
commit ab275f0915
2 changed files with 19 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/device/device_const.c
View File

@ -183,6 +183,24 @@ DEVTREE_CONST struct device *pcidev_path_behind(
return find_dev_path(parent, &path); return find_dev_path(parent, &path);
} }
DEVTREE_CONST struct device *pcidev_path_on_bus(unsigned int bus, pci_devfn_t devfn)
{
DEVTREE_CONST struct bus *parent = pci_root_bus();
DEVTREE_CONST struct device *dev = parent->children;
/* FIXME: Write the loop with topology links. */
while (dev) {
if (dev->path.type != DEVICE_PATH_PCI) {
dev = dev->next;
continue;
}
if (dev->bus->secondary == bus)
return pcidev_path_behind(dev->bus, devfn);
dev = dev->next;
}
return NULL;
}
DEVTREE_CONST struct bus *pci_root_bus(void) DEVTREE_CONST struct bus *pci_root_bus(void)
{ {
DEVTREE_CONST struct device *pci_domain; DEVTREE_CONST struct device *pci_domain;

1
src/include/device/device.h
View File

@ -288,6 +288,7 @@ DEVTREE_CONST struct device *dev_bus_each_child(const struct bus *parent,
DEVTREE_CONST struct device *pcidev_path_behind(const struct bus *parent, DEVTREE_CONST struct device *pcidev_path_behind(const struct bus *parent,
pci_devfn_t devfn); pci_devfn_t devfn);
DEVTREE_CONST struct device *pcidev_path_on_root(pci_devfn_t devfn); DEVTREE_CONST struct device *pcidev_path_on_root(pci_devfn_t devfn);
DEVTREE_CONST struct device *pcidev_path_on_bus(unsigned int bus, pci_devfn_t devfn);
DEVTREE_CONST struct device *pcidev_on_root(uint8_t dev, uint8_t fn); DEVTREE_CONST struct device *pcidev_on_root(uint8_t dev, uint8_t fn);
DEVTREE_CONST struct bus *pci_root_bus(void); DEVTREE_CONST struct bus *pci_root_bus(void);