GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/fsp_broadwell_de: Remove the enforced fsp1.0 APIs call sequence 

The enforced FSP 1.0 APIs call was used to work around an fsp1.0 driver
issue.  As the issue has been addressed in fsp1.0 driver (Change 9780),
remove the enforced workaround. Otherwise will see error message
'FSP API NotifyPhase failed' in serial log.

Verified on Intel Camelback Mountain CRB and confirmed that the serial
log error message regarding the 'FSP API NotifyPhase failed' is gone.

Change-Id: Iafa1d22e2476769fd841a3ebaa1ab4f9713c6c39
Signed-off-by: York Yang <york.yang@intel.com>
Reviewed-on: https://review.coreboot.org/16892
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
York Yang 2016-10-05 09:32:46 -07:00 committed by Martin Roth
parent f641779bac
commit ab5f3d1304
1 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/soc/intel/fsp_broadwell_de/chip.c
View File

@ -66,21 +66,9 @@ static void enable_dev(device_t dev)
} }
} }
static void fsp_notify(void *arg)
{
FspNotify (*(uint32_t *)arg);
}
static uint32_t gFspNotifyAfterPciEnumeration = EnumInitPhaseAfterPciEnumeration;
static uint32_t gFspNotifyReadtToBoot = EnumInitPhaseReadyToBoot;
static BOOT_STATE_CALLBACK(bscb_fspnotify1, fsp_notify, &gFspNotifyAfterPciEnumeration);
static BOOT_STATE_CALLBACK(bscb_fspnotify2, fsp_notify, &gFspNotifyReadtToBoot);
/* Called at BS_DEV_INIT_CHIPS time -- very early. Just after BS_PRE_DEVICE. */ /* Called at BS_DEV_INIT_CHIPS time -- very early. Just after BS_PRE_DEVICE. */
static void soc_init(void *chip_info) static void soc_init(void *chip_info)
{ {
boot_state_sched_on_exit(&bscb_fspnotify1, BS_DEV_RESOURCES);
boot_state_sched_on_exit(&bscb_fspnotify2, BS_PAYLOAD_LOAD);
broadwell_de_init_pre_device(); broadwell_de_init_pre_device();
} }