GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

intel/common/block/itss: Extend itss_irq_init() to handle IOSF 1.0 

Current implementation of itss_irq_init() uses 8 bit write access to
IRQ routing registers which is not supported on Apollo Lake.

This commit moves the register access from 8 bit to 32 bit so that this
function can be used with every platform.

Change-Id: I15c3c33a16329fd57f0ad7f99d720adbf300d094
Signed-off-by: Werner Zeh <werner.zeh@siemens.com>
Reviewed-on: https://review.coreboot.org/20680
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Werner Zeh 2017-07-21 10:22:47 +02:00
parent e4ff2b75fa
commit ab94ba309e
1 changed files with 20 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/soc/intel/common/block/itss/itss.c
View File

@ -2,6 +2,7 @@
* This file is part of the coreboot project. * This file is part of the coreboot project.
* *
* Copyright (C) 2017 Intel Corporation. * Copyright (C) 2017 Intel Corporation.
* Copyright (C) 2017 Siemens AG
* *
* This program is free software; you can redistribute it and/or modify * This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by * it under the terms of the GNU General Public License as published by
@ -23,18 +24,27 @@
void itss_irq_init(uint8_t pch_interrupt_routing[MAX_PXRC_CONFIG]) void itss_irq_init(uint8_t pch_interrupt_routing[MAX_PXRC_CONFIG])
{ {
uint8_t index = 0; uint32_t regs[MAX_PXRC_CONFIG/sizeof(uint32_t)] = {0};
uint8_t index, byte;
for (index = 0; index < MAX_PXRC_CONFIG; index++) { /* Fill in all the PIRx routes into one array. */
uint8_t val = pch_interrupt_routing[index]; for (index = 0; index < ARRAY_SIZE(regs); index++) {
uint8_t irq = val & 0xf; for (byte = 0; byte < sizeof(uint32_t); byte++) {
uint8_t val = pch_interrupt_routing[index *
sizeof(uint32_t) + byte];
uint8_t irq = val & 0xf;
if (irq == 8 || irq == 13) if ((irq <= 2) || (irq == 8) || (irq == 13))
continue; regs[index] |= (0x80 << (8 * byte));
if (irq <= 2) else
continue; regs[index] |= (val << (8 * byte));
}
pcr_write8(PID_ITSS, PCR_ITSS_PIRQA_ROUT + index, val); /* Access the routing register in 32 bit mode to make this
function suitable for both IOSF 1.0 (where only 32 bit access
is supported) and later versions of the interface. */
pcr_write32(PID_ITSS,
PCR_ITSS_PIRQA_ROUT + (index * sizeof(uint32_t)),
regs[index]);
} }
} }