GNUBoot/coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

soc/rockchip/rk3399/sdram: Add channel to error message

Browse source 
When printing error information during DRAM training, be more verbose
by printing the channel number.

Change-Id: If4109bd0573e3d9f90d699d89350ddbcc48714d3
Signed-off-by: Moritz Fischer <moritzf@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51127
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Julius Werner <jwerner@chromium.org>
This commit is contained in:
Moritz Fischer 2021-02-28 18:30:11 -08:00 committed by Julius Werner
parent 1e192138d1
commit abefcc2e2c
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/soc/rockchip/rk3399/sdram.c
View file

@ -939,7 +939,7 @@ static int data_training(u32 channel, const struct rk3399_sdram_params *params,
if ((training_flag & PI_CA_TRAINING) == PI_CA_TRAINING) {
ret = data_training_ca(channel, params);
if (ret) {
printk(BIOS_ERR, "CA training failed\n");
printk(BIOS_ERR, "Channel %d CA training failed\n", channel);
return ret;
}
}
@ -948,7 +948,7 @@ static int data_training(u32 channel, const struct rk3399_sdram_params *params,
if ((training_flag & PI_WRITE_LEVELING) == PI_WRITE_LEVELING) {
ret = data_training_wl(channel, params);
if (ret) {
printk(BIOS_ERR, "WL training failed\n");
printk(BIOS_ERR, "Channel %d WL training failed\n", channel);
return ret;
}
}
@ -957,7 +957,7 @@ static int data_training(u32 channel, const struct rk3399_sdram_params *params,
if ((training_flag & PI_READ_GATE_TRAINING) == PI_READ_GATE_TRAINING) {
ret = data_training_rg(channel, params);
if (ret) {
printk(BIOS_ERR, "RG training failed\n");
printk(BIOS_ERR, "Channel %d RG training failed\n", channel);
return ret;
}
}
@ -966,7 +966,7 @@ static int data_training(u32 channel, const struct rk3399_sdram_params *params,
if ((training_flag & PI_READ_LEVELING) == PI_READ_LEVELING) {
ret = data_training_rl(channel, params);
if (ret) {
printk(BIOS_ERR, "RL training failed\n");
printk(BIOS_ERR, "Channel %d RL training failed\n", channel);
return ret;
}
}
@ -975,7 +975,7 @@ static int data_training(u32 channel, const struct rk3399_sdram_params *params,
if ((training_flag & PI_WDQ_LEVELING) == PI_WDQ_LEVELING) {
ret = data_training_wdql(channel, params);
if (ret) {
printk(BIOS_ERR, "WDQL training failed\n");
printk(BIOS_ERR, "Channel %d WDQL training failed\n", channel);
return ret;
}
}