From ac204ba6b59bfc7d0f8c063722050b2fdb08fbb9 Mon Sep 17 00:00:00 2001 From: Furquan Shaikh Date: Fri, 19 Feb 2021 10:23:17 -0800 Subject: [PATCH] soc/amd/stoneyridge: Fix _INI method in SSDT for HDA MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit CB:40785 ("soc/amd/hda: Move HDA PCI device from DSDT to SSDT") moved the HDA device in ACPI from DSDT to SSDT. During this, _INI method generated in SSDT incorrectly inverted the values for NSEN, NSDO and NSDI. This change fixes the mistake so that the _INI in SSDT matches the original _INI in DSDT for HDA device. Change-Id: I294b561a479b77ab8afb5f3e0de367ad24f3a764 Reported-by: Kyösti Mälkki Signed-off-by: Furquan Shaikh Reviewed-on: https://review.coreboot.org/c/coreboot/+/50927 Tested-by: build bot (Jenkins) Reviewed-by: Kyösti Mälkki Reviewed-by: Angel Pons --- src/soc/amd/stoneyridge/northbridge.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/soc/amd/stoneyridge/northbridge.c b/src/soc/amd/stoneyridge/northbridge.c index c5ac90afa9..2c90d04ff9 100644 --- a/src/soc/amd/stoneyridge/northbridge.c +++ b/src/soc/amd/stoneyridge/northbridge.c @@ -530,9 +530,9 @@ void hda_soc_ssdt_quirks(const struct device *dev) acpigen_write_if_lequal_namestr_int("OSVR", 0x03); - acpigen_write_store_op_to_namestr(ONE_OP, "NSEN"); - acpigen_write_store_op_to_namestr(ZERO_OP, "NSDO"); - acpigen_write_store_op_to_namestr(ZERO_OP, "NSDI"); + acpigen_write_store_op_to_namestr(ZERO_OP, "NSEN"); + acpigen_write_store_op_to_namestr(ONE_OP, "NSDO"); + acpigen_write_store_op_to_namestr(ONE_OP, "NSDI"); acpigen_pop_len(); /* If */