GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

inteltool: Don't use PCI_FILL_SIZES 

This is supposed to fill the `size[]` array with the actual sizes of
a device' MMIO ranges, but apparently isn't implemented for every
access method in libpci (we let the library choose one). It tells us
by clearing `PCI_FILL_SIZES` in the return value of `pci_fill_info()`
(which we don't check). Since we don't ever use `size`, we can just
make it clear and don't ask for it.

Change-Id: I3fb9334472f1c7563a9e17910190f73affbe067a
Signed-off-by: Nico Huber <nico.huber@secunet.com>
Reviewed-on: https://review.coreboot.org/19582
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
Nico Huber 2017-03-31 12:09:58 +02:00 committed by Stefan Reinauer
parent a2cf686396
commit ac826c8fd7
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
util/inteltool/inteltool.c
View File

@ -425,7 +425,7 @@ int main(int argc, char *argv[])
exit(1); exit(1);
} }
pci_fill_info(sb, PCI_FILL_IDENT|PCI_FILL_BASES|PCI_FILL_SIZES|PCI_FILL_CLASS); pci_fill_info(sb, PCI_FILL_IDENT | PCI_FILL_BASES | PCI_FILL_CLASS);
if (sb->vendor_id != PCI_VENDOR_ID_INTEL) { if (sb->vendor_id != PCI_VENDOR_ID_INTEL) {
printf("Not an Intel(R) southbridge.\n"); printf("Not an Intel(R) southbridge.\n");
@ -438,7 +438,7 @@ int main(int argc, char *argv[])
exit(1); exit(1);
} }
pci_fill_info(nb, PCI_FILL_IDENT|PCI_FILL_BASES|PCI_FILL_SIZES|PCI_FILL_CLASS); pci_fill_info(nb, PCI_FILL_IDENT | PCI_FILL_BASES | PCI_FILL_CLASS);
if (nb->vendor_id != PCI_VENDOR_ID_INTEL) { if (nb->vendor_id != PCI_VENDOR_ID_INTEL) {
printf("Not an Intel(R) northbridge.\n"); printf("Not an Intel(R) northbridge.\n");
@ -448,7 +448,8 @@ int main(int argc, char *argv[])
gfx = pci_get_dev(pacc, 0, 0, 0x02, 0); gfx = pci_get_dev(pacc, 0, 0, 0x02, 0);
if (gfx) { if (gfx) {
pci_fill_info(gfx, PCI_FILL_IDENT|PCI_FILL_BASES|PCI_FILL_SIZES|PCI_FILL_CLASS); pci_fill_info(gfx, PCI_FILL_IDENT | PCI_FILL_BASES |
PCI_FILL_CLASS);
if (gfx->vendor_id != PCI_VENDOR_ID_INTEL) if (gfx->vendor_id != PCI_VENDOR_ID_INTEL)
gfx = 0; gfx = 0;
@ -460,7 +461,8 @@ int main(int argc, char *argv[])
ahci = pci_get_dev(pacc, 0, 0, 0x1f, 2); ahci = pci_get_dev(pacc, 0, 0, 0x1f, 2);
if (ahci) { if (ahci) {
pci_fill_info(ahci, PCI_FILL_IDENT|PCI_FILL_BASES|PCI_FILL_SIZES|PCI_FILL_CLASS); pci_fill_info(ahci, PCI_FILL_IDENT | PCI_FILL_BASES |
PCI_FILL_CLASS);
if (ahci->vendor_id != PCI_VENDOR_ID_INTEL) if (ahci->vendor_id != PCI_VENDOR_ID_INTEL)
ahci = 0; ahci = 0;