From ac9f36e71e7b0bf818532fdafce28247d386193e Mon Sep 17 00:00:00 2001 From: Karthikeyan Ramasubramanian Date: Tue, 30 Aug 2022 11:44:24 -0600 Subject: [PATCH] mb/google/skyrim: Fix APCB_SBR_D5.gen build rules CB:66978 introduced an incorrect condition to check for the presence of SPD binaries to be injected into APCB_SBR_D5.gen. This caused the SPDs to be not injected into the APCB and hence the system fails to boot. Fix it by updating the path of the SPD binaries correctly. BUG=b:244173966 TEST=Build and boot to OS in Skyrim. Change-Id: I5efa634fafdcc4769dfad5f533d5512e7c03644f Signed-off-by: Karthikeyan Ramasubramanian Reviewed-on: https://review.coreboot.org/c/coreboot/+/67210 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth Reviewed-by: Felix Held Reviewed-by: Raul Rangel --- src/mainboard/google/skyrim/Makefile.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mainboard/google/skyrim/Makefile.inc b/src/mainboard/google/skyrim/Makefile.inc index 0bea8a00ba..fb194d8b03 100644 --- a/src/mainboard/google/skyrim/Makefile.inc +++ b/src/mainboard/google/skyrim/Makefile.inc @@ -19,7 +19,7 @@ CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/in ifneq ($(wildcard $(MAINBOARD_BLOBS_DIR)/APCB_SBR_D5.bin),) $(info APCB sources present.) -ifneq ($(wildcard $(SPD_SOURCES)),) +ifneq ($(wildcard $(top)/$(SPD_SOURCES)),) LIB_SPD_DEPS = $(SPD_SOURCES)