GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

superio/fintek/f71863fg: Avoid .c includes 

Following the same reasoning as commit
d304331 superio/fintek/f81865f: Avoid .c includes
Clean up the early_serial #include directives in mainboard/romstage code.

Change-Id: I863c16634873224c17e43100271e9b91419724d0
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/5435
Tested-by: build bot (Jenkins)
Reviewed-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
This commit is contained in:
Edward O'Callaghan 2014-03-31 15:08:35 +11:00 committed by Alexandru Gagniuc
parent fbdc3ef7d9
commit ade70a0482
5 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/jetway/pa78vm5/romstage.c
View File

@ -42,7 +42,7 @@
#include "northbridge/amd/amdfam10/reset_test.c" #include "northbridge/amd/amdfam10/reset_test.c"
#include <console/loglevel.h> #include <console/loglevel.h>
#include "cpu/x86/bist.h" #include "cpu/x86/bist.h"
#include "superio/fintek/f71863fg/early_serial.c" #include <superio/fintek/f71863fg/f71863fg.h>
#include <cpu/amd/mtrr.h> #include <cpu/amd/mtrr.h>
#include "northbridge/amd/amdfam10/setup_resource_map.c" #include "northbridge/amd/amdfam10/setup_resource_map.c"
#include "southbridge/amd/rs780/early_setup.c" #include "southbridge/amd/rs780/early_setup.c"

2
src/superio/fintek/f71863fg/Makefile.inc
View File

@ -18,5 +18,5 @@
## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
## ##
romstage-$(CONFIG_SUPERIO_FINTEK_F71863FG) += early_serial.c
ramstage-$(CONFIG_SUPERIO_FINTEK_F71863FG) += superio.c ramstage-$(CONFIG_SUPERIO_FINTEK_F71863FG) += superio.c

2
src/superio/fintek/f71863fg/chip.h
View File

@ -29,4 +29,4 @@ struct superio_fintek_f71863fg_config {
struct pc_keyboard keyboard; struct pc_keyboard keyboard;
}; };
#endif #endif /* SUPERIO_FINTEK_F71863FG_CHIP_H */

3
src/superio/fintek/f71863fg/early_serial.c
View File

@ -21,6 +21,7 @@
/* Pre-RAM driver for the Fintek F71863FG Super I/O chip. */ /* Pre-RAM driver for the Fintek F71863FG Super I/O chip. */
#include <arch/io.h> #include <arch/io.h>
#include <device/pnp.h>
#include "f71863fg.h" #include "f71863fg.h"
static void pnp_enter_conf_state(device_t dev) static void pnp_enter_conf_state(device_t dev)
@ -36,7 +37,7 @@ static void pnp_exit_conf_state(device_t dev)
outb(0xaa, port); outb(0xaa, port);
} }
static void f71863fg_enable_serial(device_t dev, u16 iobase) void f71863fg_enable_serial(device_t dev, u16 iobase)
{ {
pnp_enter_conf_state(dev); pnp_enter_conf_state(dev);
pnp_set_logical_device(dev); pnp_set_logical_device(dev);

4
src/superio/fintek/f71863fg/f71863fg.h
View File

@ -33,4 +33,6 @@
#define F71863FG_SPI 0x08 /* SPI */ #define F71863FG_SPI 0x08 /* SPI */
#define F71863FG_PME 0x0a /* Power Management Events (PME) and ACPI */ #define F71863FG_PME 0x0a /* Power Management Events (PME) and ACPI */
#endif void f71863fg_enable_serial(device_t dev, u16 iobase);
#endif /* SUPERIO_FINTEK_F71863FG_F71863FG_H */