From adeac8d4f76c8ac33ee56613c79b746547dd12a6 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Wed, 23 Jun 2021 12:32:59 +0200 Subject: [PATCH] soc/intel/apollolake: Drop `xdci_can_enable()` call The `xdci_can_enable()` function is called earlier to configure FSP-S UPDs. If it returned false, then the xDCI device will be disabled and the second `xdci_can_enable()` call will never be evaluated. Change-Id: I4bd08e3194ffccc79c8feaf8f34b2bb4077f760a Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/55789 Reviewed-by: Subrata Banik Tested-by: build bot (Jenkins) --- src/soc/intel/apollolake/xdci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/soc/intel/apollolake/xdci.c b/src/soc/intel/apollolake/xdci.c index 8c86e442ec..5903e34bcc 100644 --- a/src/soc/intel/apollolake/xdci.c +++ b/src/soc/intel/apollolake/xdci.c @@ -40,7 +40,7 @@ static void configure_host_mode_port0(struct device *dev) * enabled. If it's disabled assume the switch was already done * in FSP. */ - if (!dev->enabled || !xdci_can_enable()) + if (!dev->enabled) return; printk(BIOS_INFO, "Putting port 0 into host mode.\n");