From adfaea5400248a5f729cf29d5bbdaa6d199f1c23 Mon Sep 17 00:00:00 2001 From: Joel Kitching Date: Thu, 23 Aug 2018 15:39:26 +0800 Subject: [PATCH] acpi/gnvs: delay setting chromeos_apci_t.vdat until depthcharge Standardize on using vboot_handoff data structure for transferring data between coreboot and depthcharge. chromeos_acpi_t.vdat is undefined until set in depthcharge. BUG=b:112288216 TEST=compile and run on eve CQ-DEPEND=CL:1198814 Change-Id: Iccc021334d3c6f0145dffd5ca05beb9e430378a9 Signed-off-by: Joel Kitching Reviewed-on: https://review.coreboot.org/28407 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin Reviewed-by: Furquan Shaikh --- src/vendorcode/google/chromeos/gnvs.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/vendorcode/google/chromeos/gnvs.c b/src/vendorcode/google/chromeos/gnvs.c index f21eb0963c..86ba4f3353 100644 --- a/src/vendorcode/google/chromeos/gnvs.c +++ b/src/vendorcode/google/chromeos/gnvs.c @@ -37,12 +37,6 @@ void chromeos_init_chromeos_acpi(chromeos_acpi_t *init) /* Copy saved ME hash into NVS */ memcpy(chromeos_acpi->mehh, me_hash_saved, sizeof(chromeos_acpi->mehh)); - struct vboot_handoff *vboot_handoff; - - if (vboot_get_handoff_info((void **)&vboot_handoff, NULL) == 0) - memcpy(&chromeos_acpi->vdat[0], &vboot_handoff->shared_data[0], - ARRAY_SIZE(chromeos_acpi->vdat)); - chromeos_ram_oops_init(chromeos_acpi); }