GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/{brya,brox,rex}: Update ec_sync wake capability 

Some of the boards use the EC_SYNC pin to wake the AP but do not
advertise the pin as wake capable in the CREC _CRS resource.  Relevant
boards were determined through empirical testing and inspection of gpio
configuration.

Update the ACPI tables for rex, brya, and brox based boards to advertise
their EC_SYNC pin as wake capable.

BUG=b:243700486
TEST=-Dump ACPI and verify ExclusiveAndWake share type is set when
     EC_SYNC_IRQ_WAKE_CAPABLE is defined
     -Wake Aviko via keypress and verify chromeos-ec as wake source
     -Wake Screebo via lid open and verify chromeos-ec as wake source
Change-Id: I5828be7c9420cab6ae838272c8301c302a3e078c
Signed-off-by: Mark Hasemeyer <markhas@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79374
Reviewed-by: Eric Lai <ericllai@google.com>
Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Subrata Banik <subratabanik@google.com>
This commit is contained in:
Mark Hasemeyer 2023-11-29 16:19:42 -07:00 committed by Subrata Banik
parent 677d15e8a8
commit aef345bfd7
6 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/mainboard/google/brox/variants/baseboard/brox/include/baseboard/ec.h
View File

@ -75,5 +75,6 @@
#define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */
#define EC_ENABLE_SYNC_IRQ /* Enable tight timestamp / wake support */
#define EC_SYNC_IRQ_WAKE_CAPABLE /* Let the OS know ec_sync is wake capable */
#endif /* __BASEBOARD_EC_H__ */

1
src/mainboard/google/brya/variants/baseboard/brask/include/baseboard/ec.h
View File

@ -41,5 +41,6 @@
#define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */
#define EC_ENABLE_SYNC_IRQ /* Enable tight timestamp / wake support */
#define EC_SYNC_IRQ_WAKE_CAPABLE /* Let the OS know ec_sync is wake capable */
#endif /* __BASEBOARD_EC_H__ */

1
src/mainboard/google/brya/variants/baseboard/brya/include/baseboard/ec.h
View File

@ -80,5 +80,6 @@
#define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */
#define EC_ENABLE_SYNC_IRQ /* Enable tight timestamp / wake support */
#define EC_SYNC_IRQ_WAKE_CAPABLE /* Let the OS know ec_sync is wake capable */
#endif /* __BASEBOARD_EC_H__ */

1
src/mainboard/google/brya/variants/baseboard/hades/include/baseboard/ec.h
View File

@ -70,5 +70,6 @@
#define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */
#define EC_ENABLE_SYNC_IRQ /* Enable tight timestamp / wake support */
#define EC_SYNC_IRQ_WAKE_CAPABLE /* Let the OS know ec_sync is wake capable */
#endif /* __BASEBOARD_EC_H__ */

1
src/mainboard/google/rex/variants/baseboard/ovis/include/baseboard/ec.h
View File

@ -60,5 +60,6 @@
#define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */
#define EC_ENABLE_SYNC_IRQ /* Enable tight timestamp / wake support */
#define EC_SYNC_IRQ_WAKE_CAPABLE /* Let the OS know ec_sync is wake capable */
#endif /* __BASEBOARD_EC_H__ */

1
src/mainboard/google/rex/variants/baseboard/rex/include/baseboard/ec.h
View File

@ -74,5 +74,6 @@
#define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */
#define EC_ENABLE_SYNC_IRQ /* Enable tight timestamp / wake support */
#define EC_SYNC_IRQ_WAKE_CAPABLE /* Let the OS know ec_sync is wake capable */
#endif /* __BASEBOARD_EC_H__ */