When debug logging is enabled, a message such as '* AP 02 timed out:02010501'

Browse Source

is sometimes logged. The reason is that the AP first sets a completion value
such as 0x13, which is what function wait_cpu_state() is waiting for. Then a
short time later, the AP calls function init_fidvid_ap(). This function sets
a completion value of 01. When logging is off, wait_cpu_state is fast enough
to see the initial completion value for each of the APs. But with logging
enabled, one or more APs may go on to complete function init_fidvid_ap, which
sets the completion value to 01. While mostly harmless, the timeout does
increase boot time. This patch eliminates the timeout by making function
wait_cpu_state recognize 01 as an additional valid AP completion value.

Signed-off-by: Scott Duplichan <scott@notabs.org>
Acked-by: Peter Stuge <peter@stuge.se>


git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5966 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

...

This commit is contained in:

Scott Duplichan 2010-10-19 04:26:17 +00:00

parent d7acdfb44a

commit af786b618d

3 changed files with 2985 additions and 2978 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1676

src/cpu/amd/model_10xxx/fidvid.c

View File

File diff suppressed because it is too large Load Diff

1893

src/cpu/amd/model_10xxx/init_cpus.c

View File

File diff suppressed because it is too large Load Diff

2394

src/northbridge/amd/amdfam10/amdfam10.h

View File

File diff suppressed because it is too large Load Diff