GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ec/lenovo/pmh7/chip.h: Use 'bool' instead of 'int' 

This to fix following error using Clang-16.0.0:
/cb-build/coreboot-toolchain.0/clang/LENOVO_W500/mainboard/lenovo/t400/static.c:135:22: error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
        .backlight_enable = 0x01,
                            ^~~~
/cb-build/coreboot-toolchain.0/clang/LENOVO_W500/mainboard/lenovo/t400/static.c:136:23: error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
        .dock_event_enable = 0x01,
                             ^~~~

Change-Id: Icd35224877fee355e1bbb8a8e838cb047604babb
Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73810
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Singer <felixsinger@posteo.net>
This commit is contained in:
Elyes Haouas 2023-03-19 08:01:53 +01:00
parent c46242f904
commit af93336da3
21 changed files with 42 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/ec/lenovo/pmh7/chip.h
View File

@ -3,9 +3,11 @@
#ifndef EC_LENOVO_PMH7_CHIP_H #ifndef EC_LENOVO_PMH7_CHIP_H
#define EC_LENOVO_PMH7_CHIP_H #define EC_LENOVO_PMH7_CHIP_H
#include <stdbool.h>
struct ec_lenovo_pmh7_config { struct ec_lenovo_pmh7_config {
int backlight_enable:1; bool backlight_enable;
int dock_event_enable:1; bool dock_event_enable;
}; };
#endif /* EC_LENOVO_PMH7_CHIP_H */ #endif /* EC_LENOVO_PMH7_CHIP_H */

4
src/mainboard/lenovo/haswell/variants/t440p/devicetree.cb
View File

@ -55,8 +55,8 @@ chip northbridge/intel/haswell
device pci 1d.0 on end # USB2 EHCI #1 device pci 1d.0 on end # USB2 EHCI #1
device pci 1f.0 on # LPC bridge device pci 1f.0 on # LPC bridge
chip ec/lenovo/pmh7 chip ec/lenovo/pmh7
register "backlight_enable" = "0x01" register "backlight_enable" = "true"
register "dock_event_enable" = "0x01" register "dock_event_enable" = "true"
device pnp ff.1 on end # dummy device pnp ff.1 on end # dummy
end end
chip ec/lenovo/h8 chip ec/lenovo/h8

4
src/mainboard/lenovo/haswell/variants/w541/devicetree.cb
View File

@ -54,8 +54,8 @@ chip northbridge/intel/haswell
device pci 1d.0 on end # USB2 EHCI #1 device pci 1d.0 on end # USB2 EHCI #1
device pci 1f.0 on # LPC bridge device pci 1f.0 on # LPC bridge
chip ec/lenovo/pmh7 chip ec/lenovo/pmh7
register "backlight_enable" = "0x01" register "backlight_enable" = "true"
register "dock_event_enable" = "0x01" register "dock_event_enable" = "true"
device pnp ff.1 on end # dummy device pnp ff.1 on end # dummy
end end
chip ec/lenovo/h8 # FIXME: has_power_management_beeps, has_uwb chip ec/lenovo/h8 # FIXME: has_power_management_beeps, has_uwb

4
src/mainboard/lenovo/l520/devicetree.cb
View File

@ -54,8 +54,8 @@ chip northbridge/intel/sandybridge
device ref pci_bridge off end # PCI bridge device ref pci_bridge off end # PCI bridge
device ref lpc on # LPC bridge PCI-LPC bridge device ref lpc on # LPC bridge PCI-LPC bridge
chip ec/lenovo/pmh7 chip ec/lenovo/pmh7
register "backlight_enable" = "0x01" register "backlight_enable" = "true"
register "dock_event_enable" = "0x01" register "dock_event_enable" = "true"
device pnp ff.1 on end # dummy device pnp ff.1 on end # dummy
end end
chip ec/lenovo/h8 chip ec/lenovo/h8

4
src/mainboard/lenovo/t400/devicetree.cb
View File

@ -120,8 +120,8 @@ chip northbridge/intel/gm45
chip ec/lenovo/pmh7 chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy device pnp ff.1 on end # dummy
register "backlight_enable" = "0x01" register "backlight_enable" = "true"
register "dock_event_enable" = "0x01" register "dock_event_enable" = "true"
end end
chip ec/lenovo/h8 chip ec/lenovo/h8

4
src/mainboard/lenovo/t410/devicetree.cb
View File

@ -99,8 +99,8 @@ chip northbridge/intel/ironlake
end end
chip ec/lenovo/pmh7 chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy device pnp ff.1 on end # dummy
register "backlight_enable" = "0x01" register "backlight_enable" = "true"
register "dock_event_enable" = "0x01" register "dock_event_enable" = "true"
end end
chip ec/lenovo/h8 chip ec/lenovo/h8
device pnp ff.2 on # dummy device pnp ff.2 on # dummy

4
src/mainboard/lenovo/t420/devicetree.cb
View File

@ -77,8 +77,8 @@ chip northbridge/intel/sandybridge
device ref lpc on device ref lpc on
chip ec/lenovo/pmh7 chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy device pnp ff.1 on end # dummy
register "backlight_enable" = "0x01" register "backlight_enable" = "true"
register "dock_event_enable" = "0x01" register "dock_event_enable" = "true"
end end
chip drivers/pc80/tpm chip drivers/pc80/tpm

4
src/mainboard/lenovo/t420s/devicetree.cb
View File

@ -75,8 +75,8 @@ chip northbridge/intel/sandybridge
device ref lpc on device ref lpc on
chip ec/lenovo/pmh7 chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy device pnp ff.1 on end # dummy
register "backlight_enable" = "0x01" register "backlight_enable" = "true"
register "dock_event_enable" = "0x01" register "dock_event_enable" = "true"
end end
chip drivers/pc80/tpm chip drivers/pc80/tpm

4
src/mainboard/lenovo/t430/devicetree.cb
View File

@ -64,8 +64,8 @@ chip northbridge/intel/sandybridge
device ref pci_bridge off end # PCI bridge device ref pci_bridge off end # PCI bridge
device ref lpc on # LPC bridge PCI-LPC bridge device ref lpc on # LPC bridge PCI-LPC bridge
chip ec/lenovo/pmh7 chip ec/lenovo/pmh7
register "backlight_enable" = "0x01" register "backlight_enable" = "true"
register "dock_event_enable" = "0x01" register "dock_event_enable" = "true"
device pnp ff.1 on end # dummy device pnp ff.1 on end # dummy
end end
chip ec/lenovo/h8 chip ec/lenovo/h8

4
src/mainboard/lenovo/t430s/devicetree.cb
View File

@ -77,8 +77,8 @@ chip northbridge/intel/sandybridge
device ref lpc on device ref lpc on
chip ec/lenovo/pmh7 chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy device pnp ff.1 on end # dummy
register "backlight_enable" = "0x01" register "backlight_enable" = "true"
register "dock_event_enable" = "0x01" register "dock_event_enable" = "true"
end end
chip drivers/pc80/tpm chip drivers/pc80/tpm

4
src/mainboard/lenovo/t520/devicetree.cb
View File

@ -73,8 +73,8 @@ chip northbridge/intel/sandybridge
device ref lpc on #LPC bridge device ref lpc on #LPC bridge
chip ec/lenovo/pmh7 chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy device pnp ff.1 on end # dummy
register "backlight_enable" = "0x01" register "backlight_enable" = "true"
register "dock_event_enable" = "0x01" register "dock_event_enable" = "true"
end end
chip drivers/pc80/tpm chip drivers/pc80/tpm

4
src/mainboard/lenovo/t530/devicetree.cb
View File

@ -78,8 +78,8 @@ chip northbridge/intel/sandybridge
device ref lpc on # PCI-LPC bridge device ref lpc on # PCI-LPC bridge
chip ec/lenovo/pmh7 chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy device pnp ff.1 on end # dummy
register "backlight_enable" = "0x01" register "backlight_enable" = "true"
register "dock_event_enable" = "0x01" register "dock_event_enable" = "true"
end end
chip drivers/pc80/tpm chip drivers/pc80/tpm

4
src/mainboard/lenovo/t60/devicetree.cb
View File

@ -109,8 +109,8 @@ chip northbridge/intel/i945
subsystemid 0x17aa 0x2009 subsystemid 0x17aa 0x2009
chip ec/lenovo/pmh7 chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy device pnp ff.1 on end # dummy
register "backlight_enable" = "0x01" register "backlight_enable" = "true"
register "dock_event_enable" = "0x01" register "dock_event_enable" = "true"
end end
chip ec/lenovo/h8 chip ec/lenovo/h8
device pnp ff.2 on # dummy device pnp ff.2 on # dummy

4
src/mainboard/lenovo/x1_carbon_gen1/devicetree.cb
View File

@ -77,8 +77,8 @@ chip northbridge/intel/sandybridge
device ref lpc on #LPC bridge device ref lpc on #LPC bridge
chip ec/lenovo/pmh7 chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy device pnp ff.1 on end # dummy
register "backlight_enable" = "0x01" register "backlight_enable" = "true"
register "dock_event_enable" = "0x01" register "dock_event_enable" = "true"
end end
chip drivers/pc80/tpm chip drivers/pc80/tpm

2
src/mainboard/lenovo/x200/devicetree.cb
View File

@ -110,7 +110,7 @@ chip northbridge/intel/gm45
chip ec/lenovo/pmh7 chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy device pnp ff.1 on end # dummy
register "backlight_enable" = "0x01" register "backlight_enable" = "true"
end end
chip ec/lenovo/h8 chip ec/lenovo/h8

2
src/mainboard/lenovo/x200/variants/x200/overridetree.cb
View File

@ -17,7 +17,7 @@ chip northbridge/intel/gm45
device pci 1f.0 on # LPC bridge device pci 1f.0 on # LPC bridge
chip ec/lenovo/pmh7 chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy device pnp ff.1 on end # dummy
register "dock_event_enable" = "0x01" register "dock_event_enable" = "true"
end end
chip superio/nsc/pc87382 chip superio/nsc/pc87382
device pnp 164e.3 on # Digitizer device pnp 164e.3 on # Digitizer

4
src/mainboard/lenovo/x201/devicetree.cb
View File

@ -106,8 +106,8 @@ chip northbridge/intel/ironlake
chip ec/lenovo/pmh7 chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy device pnp ff.1 on end # dummy
register "backlight_enable" = "0x01" register "backlight_enable" = "true"
register "dock_event_enable" = "0x01" register "dock_event_enable" = "true"
end end
chip ec/lenovo/h8 chip ec/lenovo/h8

4
src/mainboard/lenovo/x220/devicetree.cb
View File

@ -78,8 +78,8 @@ chip northbridge/intel/sandybridge
device ref lpc on #LPC bridge device ref lpc on #LPC bridge
chip ec/lenovo/pmh7 chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy device pnp ff.1 on end # dummy
register "backlight_enable" = "0x01" register "backlight_enable" = "true"
register "dock_event_enable" = "0x01" register "dock_event_enable" = "true"
end end
chip drivers/pc80/tpm chip drivers/pc80/tpm

4
src/mainboard/lenovo/x230/devicetree.cb
View File

@ -80,8 +80,8 @@ chip northbridge/intel/sandybridge
device ref lpc on #LPC bridge device ref lpc on #LPC bridge
chip ec/lenovo/pmh7 chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy device pnp ff.1 on end # dummy
register "backlight_enable" = "0x01" register "backlight_enable" = "true"
register "dock_event_enable" = "0x01" register "dock_event_enable" = "true"
end end
chip drivers/pc80/tpm chip drivers/pc80/tpm

4
src/mainboard/lenovo/x60/devicetree.cb
View File

@ -97,8 +97,8 @@ chip northbridge/intel/i945
subsystemid 0x17aa 0x2009 subsystemid 0x17aa 0x2009
chip ec/lenovo/pmh7 chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy device pnp ff.1 on end # dummy
register "backlight_enable" = "0x01" register "backlight_enable" = "true"
register "dock_event_enable" = "0x01" register "dock_event_enable" = "true"
end end
chip ec/lenovo/h8 chip ec/lenovo/h8
device pnp ff.2 on # dummy device pnp ff.2 on # dummy

4
util/autoport/ec_lenovo.go
View File

@ -155,8 +155,8 @@ void mainboard_smi_sleep(u8 slp_typ)
pmh := DevTreeNode{ pmh := DevTreeNode{
Chip: "ec/lenovo/pmh7", Chip: "ec/lenovo/pmh7",
Registers: map[string]string{ Registers: map[string]string{
"backlight_enable": "0x01", "backlight_enable": "true",
"dock_event_enable": "0x01", "dock_event_enable": "true",
}, },
Children: []DevTreeNode{ Children: []DevTreeNode{
DevTreeNode{ DevTreeNode{