GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/gigabyte/ga-h61m-s2pv: Improve LPC decoding 

Drop unused CNF2_LPC_EN, as there is no device which uses IO 0x4e/4f.

Do not use the mainboard model to set COMA_LPC_EN. Make use of
NO_UART_ON_SUPERIO instead, as it is more future-proof.

Change-Id: Iac49250b0f509a42012f82db8aa85ba85559c66f
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35444
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
Angel Pons 2019-09-17 10:51:15 +02:00 committed by Patrick Georgi
parent 8eb34dbe57
commit afa6a2de48
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/mainboard/gigabyte/ga-h61m-s2pv/romstage.c
View File

@ -25,14 +25,11 @@
void pch_enable_lpc(void)
{
if (CONFIG(BOARD_GIGABYTE_GA_H61M_S2PV)) {
pci_write_config16(PCH_LPC_DEV, LPC_EN, KBC_LPC_EN |
CNF1_LPC_EN | CNF2_LPC_EN | COMA_LPC_EN);
pci_write_config16(PCH_LPC_DEV, LPC_IO_DEC, 0x10);
pci_write_config16(PCH_LPC_DEV, LPC_EN, KBC_LPC_EN | CNF1_LPC_EN);
} else if (CONFIG(BOARD_GIGABYTE_GA_H61MA_D3V)) {
pci_write_config16(PCH_LPC_DEV, LPC_EN, KBC_LPC_EN |
CNF1_LPC_EN);
if (!CONFIG(NO_UART_ON_SUPERIO)) {
pci_or_config16(PCH_LPC_DEV, LPC_EN, COMA_LPC_EN);
pci_write_config16(PCH_LPC_DEV, LPC_IO_DEC, 0x10);
}
}