GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ec/roda/it8518/acpi: Use lower-case hex format 

Built roda/rw11 with `BUILD_TIMELESS=1` and coreboot.rom remains the
same.

Change-Id: I9f08b048d41ab7a5d7d7dc735779ea019517491a
Signed-off-by: Felix Singer <felix.singer@secunet.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56608
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Felix Singer 2021-07-26 19:21:42 +02:00 committed by Nico Huber
parent ee00ad3513
commit afa6c41a80
2 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/ec/roda/it8518/acpi/battery.asl
View File

@ -33,9 +33,9 @@ Device (BAT0)
Name (PBST, Package (4) Name (PBST, Package (4)
{ {
0x00000000, // Battery State 0x00000000, // Battery State
0xFFFFFFFF, // Battery Present Rate 0xffffffff, // Battery Present Rate
0xFFFFFFFF, // Battery Remaining Capacity 0xffffffff, // Battery Remaining Capacity
0xFFFFFFFF, // Battery Present Voltage 0xffffffff, // Battery Present Voltage
}) })
@ -44,13 +44,13 @@ Device (BAT0)
{ {
Printf ("-----> BAT0: _STA") Printf ("-----> BAT0: _STA")
Local0 = 0x0F Local0 = 0x0f
Local1 = ECPS Local1 = ECPS
Local1 &= 0x02 Local1 &= 0x02
If (Local1 == 0x02) If (Local1 == 0x02)
{ {
Local0 = 0x1F Local0 = 0x1f
} }
Printf ("<----- BAT0: _STA") Printf ("<----- BAT0: _STA")

14
src/ec/roda/it8518/acpi/ec.asl
View File

@ -11,7 +11,7 @@ Device (EC0)
Name (LIDS, 1) Name (LIDS, 1)
// EC RAM fields // EC RAM fields
OperationRegion(ERAM, EmbeddedControl, 0, 0xFF) OperationRegion(ERAM, EmbeddedControl, 0, 0xff)
Field (ERAM, ByteAcc, NoLock, Preserve) Field (ERAM, ByteAcc, NoLock, Preserve)
{ {
Offset(0x02), // [Configuration Space 0x2] Offset(0x02), // [Configuration Space 0x2]
@ -31,13 +31,13 @@ Device (EC0)
Offset (0x50), // [Configuration Space 0x50] Offset (0x50), // [Configuration Space 0x50]
LUXH, 8, // Ambient Light Illuminance High LUXH, 8, // Ambient Light Illuminance High
LUXL, 8, // Ambient Light Illuminance Low LUXL, 8, // Ambient Light Illuminance Low
Offset (0x5B), // [Configuration Space 0x5B] Offset (0x5b), // [Configuration Space 0x5b]
BRIG, 8, // Brightness BRIG, 8, // Brightness
} // End of ERAM } // End of ERAM
Method (_STA, 0, NotSerialized) // _STA: Status Method (_STA, 0, NotSerialized) // _STA: Status
{ {
Return (0x0F) Return (0x0f)
} }
Method (_CRS, 0, NotSerialized) Method (_CRS, 0, NotSerialized)
@ -134,8 +134,8 @@ Device (EC0)
Local0 = BRIG Local0 = BRIG
Local0 += 1 Local0 += 1
If (Local0 > 0xAA) { If (Local0 > 0xaa) {
Local0 = 0xAA Local0 = 0xaa
} }
BRIG = Local0 BRIG = Local0
@ -150,9 +150,9 @@ Device (EC0)
Local0 = BRIG Local0 = BRIG
Local0 -= 1 Local0 -= 1
If (Local0 < 0xA0) If (Local0 < 0xa0)
{ {
Local0 = 0xA0 Local0 = 0xa0
} }
BRIG = Local0 BRIG = Local0