GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

veyron_rialto: Turn on all leds 

Without this, the leds would be stuck to whatever the pullup/down states the
pins come with on rk3288.

Ready2_LED, an orange led, is one of the leds in this state.
This might confuse some users thinking there's an error.

Turn all of them on instead.
Later on depthcharge will use the same LEDs to indicate dev mode status.

BUG=chrome-os-partner:44274
BRANCH=master
TEST=Boot firmware without anything else, note all leds on

Change-Id: I5cf19aabd2a59a61699ef491ae11424cf5a0c874
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Original-Commit-Id: 2e1a332a5653fb76bbf8fe624274ec64d2b443a5
Original-Change-Id: I4c4e8940dd9cf1ac0301ac00bfc5992ba16e1589
Original-Signed-off-by: Alexandru M Stan <amstan@chromium.org>
Original-Reviewed-on: https://chromium-review.googlesource.com/294065
Original-Reviewed-by: David Hendricks <dhendrix@chromium.org>
Reviewed-on: http://review.coreboot.org/11398
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
Alexandru M Stan 2015-08-17 17:32:06 -07:00 committed by Patrick Georgi
parent bedbdc4566
commit affb88b271
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/mainboard/google/veyron_rialto/bootblock.c
View File

@ -48,6 +48,12 @@ void bootblock_mainboard_init(void)
if (rkclk_was_watchdog_reset()) if (rkclk_was_watchdog_reset())
reboot_from_watchdog(); reboot_from_watchdog();
/* Turn on all leds */
gpio_output(GPIO(7, A, 0), 1); /* LED_READY */
gpio_output(GPIO(7, B, 5), 1); /* Ready2_LED */
gpio_output(GPIO(7, B, 3), 1); /* LED_SYNCING */
gpio_output(GPIO(7, B, 7), 1); /* LED_ERROR */
/* Up VDD_CPU (BUCK1) to 1.4V to support max CPU frequency (1.8GHz). */ /* Up VDD_CPU (BUCK1) to 1.4V to support max CPU frequency (1.8GHz). */
setbits_le32(&rk3288_pmu->iomux_i2c0scl, IOMUX_I2C0SCL); setbits_le32(&rk3288_pmu->iomux_i2c0scl, IOMUX_I2C0SCL);
setbits_le32(&rk3288_pmu->iomux_i2c0sda, IOMUX_I2C0SDA); setbits_le32(&rk3288_pmu->iomux_i2c0sda, IOMUX_I2C0SDA);