From b10afbd2e2a8326fb21dc726a6c2bd53b06eb010 Mon Sep 17 00:00:00 2001 From: Bernardo Perez Priego Date: Tue, 15 Jun 2021 17:26:31 -0700 Subject: [PATCH] mb/intel/adlrvp_m: Configure DP_HPD as PAD_NC and disable DdiPortHpd GPP_A19(DP_HPD1) and GPP_A20(DP_HPD2) were configured native function (NF1), this causes redundancy with legacy HPD interruption. This change configures GPP_A19 and GPP_A20 to be no connection and disables DdiPort1Hpd and DdiPort2Hpd. BUG=None TEST=Boot to kernel and verified no kernel HPD pins assertion message. Signed-off-by: Bernardo Perez Priego Change-Id: I80ef40a1aca19cd6ad56219175d2fd40890a393d Reviewed-on: https://review.coreboot.org/c/coreboot/+/55548 Tested-by: build bot (Jenkins) Reviewed-by: Sanrio Alvares Reviewed-by: Bora Guvendik --- src/mainboard/intel/adlrvp/devicetree_m.cb | 4 ++++ src/mainboard/intel/adlrvp/gpio_m.c | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/mainboard/intel/adlrvp/devicetree_m.cb b/src/mainboard/intel/adlrvp/devicetree_m.cb index ae248429a9..4d32ce9135 100644 --- a/src/mainboard/intel/adlrvp/devicetree_m.cb +++ b/src/mainboard/intel/adlrvp/devicetree_m.cb @@ -86,6 +86,10 @@ chip soc/intel/alderlake [DDI_PORT_B] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, }" + # Disable DDI ports HPD + register "DdiPort1Hpd" = "0" + register "DdiPort2Hpd" = "0" + # TCSS USB3 register "TcssAuxOri" = "0" diff --git a/src/mainboard/intel/adlrvp/gpio_m.c b/src/mainboard/intel/adlrvp/gpio_m.c index 6f89fd2240..d5eeffa1c4 100644 --- a/src/mainboard/intel/adlrvp/gpio_m.c +++ b/src/mainboard/intel/adlrvp/gpio_m.c @@ -110,7 +110,9 @@ static const struct pad_config gpio_table[] = { /* HPD_1 (E14) and HPD_2 (A18) pins */ PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1), PAD_CFG_NF(GPP_A18, NONE, DEEP, NF1), - PAD_CFG_NF(GPP_A19, NONE, DEEP, NF1), + + PAD_NC(GPP_A19, NONE), + PAD_NC(GPP_A20, NONE), /* GPIO pin for PCIE SRCCLKREQB */ PAD_CFG_NF(GPP_D5, NONE, DEEP, NF1),