GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cpu/x86/smm/smm_module_loaderv2.c: Use more variables 

Reusing the 'size' variable for a different purpose later on in the
function makes the code harder to read.

Change-Id: Iceb10aa40ad473b41b7da0310554725585e3c2c2
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47070
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: David Hendricks <david.hendricks@gmail.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Arthur Heymans 2020-11-01 21:04:55 +01:00 committed by Patrick Georgi
parent fd8619e665
commit b17f11e19d
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/cpu/x86/smm/smm_module_loaderv2.c
View File

@ -413,12 +413,14 @@ static int smm_module_setup_stub(void *smbase, size_t smm_size,
* for default handler, but for relocated handler it lives at the beginning
* of SMRAM which is TSEG base
*/
size = params->num_concurrent_stacks * params->per_cpu_stack_size;
stacks_top = smm_stub_place_stacks((char *)params->smram_start, size, params);
const size_t total_stack_size = params->num_concurrent_stacks *
params->per_cpu_stack_size;
stacks_top = smm_stub_place_stacks((char *)params->smram_start, total_stack_size,
params);
if (stacks_top == NULL) {
printk(BIOS_ERR, "%s: not enough space for stacks\n", __func__);
printk(BIOS_ERR, "%s: ....need -> %p : available -> %zx\n", __func__,
base, size);
base, total_stack_size);
return -1;
}
params->stack_top = stacks_top;