sb,soc/intel: Remove no-op APMC for C-state and P-state
Change-Id: I3c1aa7f68eb03f04ddb9c1a5e960e3e2050a029c Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/49250 Reviewed-by: Angel Pons <th3fanbus@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
parent
c1d524b8c6
commit
b218c20c00
|
@ -283,20 +283,6 @@ static void southbridge_smi_apmc(void)
|
|||
|
||||
reg8 = apm_get_apmc();
|
||||
switch (reg8) {
|
||||
case APM_CNT_CST_CONTROL:
|
||||
/*
|
||||
* Calling this function seems to cause
|
||||
* some kind of race condition in Linux
|
||||
* and causes a kernel oops
|
||||
*/
|
||||
break;
|
||||
case APM_CNT_PST_CONTROL:
|
||||
/*
|
||||
* Calling this function seems to cause
|
||||
* some kind of race condition in Linux
|
||||
* and causes a kernel oops
|
||||
*/
|
||||
break;
|
||||
case APM_CNT_ACPI_DISABLE:
|
||||
disable_pm1_control(SCI_EN);
|
||||
break;
|
||||
|
|
|
@ -262,20 +262,6 @@ static void southbridge_smi_apmc(void)
|
|||
|
||||
reg8 = apm_get_apmc();
|
||||
switch (reg8) {
|
||||
case APM_CNT_CST_CONTROL:
|
||||
/*
|
||||
* Calling this function seems to cause
|
||||
* some kind of race condition in Linux
|
||||
* and causes a kernel oops
|
||||
*/
|
||||
break;
|
||||
case APM_CNT_PST_CONTROL:
|
||||
/*
|
||||
* Calling this function seems to cause
|
||||
* some kind of race condition in Linux
|
||||
* and causes a kernel oops
|
||||
*/
|
||||
break;
|
||||
case APM_CNT_ACPI_DISABLE:
|
||||
disable_pm1_control(SCI_EN);
|
||||
break;
|
||||
|
|
|
@ -314,10 +314,6 @@ static void southbridge_smi_apmc(void)
|
|||
|
||||
reg8 = apm_get_apmc();
|
||||
switch (reg8) {
|
||||
case APM_CNT_CST_CONTROL:
|
||||
break;
|
||||
case APM_CNT_PST_CONTROL:
|
||||
break;
|
||||
case APM_CNT_ACPI_DISABLE:
|
||||
disable_pm1_control(SCI_EN);
|
||||
break;
|
||||
|
|
|
@ -333,20 +333,6 @@ void smihandler_southbridge_apmc(
|
|||
|
||||
reg8 = apm_get_apmc();
|
||||
switch (reg8) {
|
||||
case APM_CNT_CST_CONTROL:
|
||||
/*
|
||||
* Calling this function seems to cause
|
||||
* some kind of race condition in Linux
|
||||
* and causes a kernel oops
|
||||
*/
|
||||
break;
|
||||
case APM_CNT_PST_CONTROL:
|
||||
/*
|
||||
* Calling this function seems to cause
|
||||
* some kind of race condition in Linux
|
||||
* and causes a kernel oops
|
||||
*/
|
||||
break;
|
||||
case APM_CNT_ACPI_DISABLE:
|
||||
pmc_disable_pm1_control(SCI_EN);
|
||||
break;
|
||||
|
|
|
@ -222,18 +222,6 @@ static void southbridge_smi_apmc(void)
|
|||
|
||||
reg8 = apm_get_apmc();
|
||||
switch (reg8) {
|
||||
case APM_CNT_CST_CONTROL:
|
||||
/* Calling this function seems to cause
|
||||
* some kind of race condition in Linux
|
||||
* and causes a kernel oops
|
||||
*/
|
||||
break;
|
||||
case APM_CNT_PST_CONTROL:
|
||||
/* Calling this function seems to cause
|
||||
* some kind of race condition in Linux
|
||||
* and causes a kernel oops
|
||||
*/
|
||||
break;
|
||||
case APM_CNT_ACPI_DISABLE:
|
||||
disable_pm1_control(SCI_EN);
|
||||
break;
|
||||
|
|
|
@ -277,18 +277,6 @@ static void southbridge_smi_apmc(void)
|
|||
|
||||
reg8 = apm_get_apmc();
|
||||
switch (reg8) {
|
||||
case APM_CNT_CST_CONTROL:
|
||||
/* Calling this function seems to cause
|
||||
* some kind of race condition in Linux
|
||||
* and causes a kernel oops
|
||||
*/
|
||||
break;
|
||||
case APM_CNT_PST_CONTROL:
|
||||
/* Calling this function seems to cause
|
||||
* some kind of race condition in Linux
|
||||
* and causes a kernel oops
|
||||
*/
|
||||
break;
|
||||
case APM_CNT_ACPI_DISABLE:
|
||||
write_pmbase32(PM1_CNT, read_pmbase32(PM1_CNT) & ~SCI_EN);
|
||||
break;
|
||||
|
|
|
@ -299,18 +299,6 @@ static void southbridge_smi_apmc(void)
|
|||
|
||||
reg8 = apm_get_apmc();
|
||||
switch (reg8) {
|
||||
case APM_CNT_CST_CONTROL:
|
||||
/* Calling this function seems to cause
|
||||
* some kind of race condition in Linux
|
||||
* and causes a kernel oops
|
||||
*/
|
||||
break;
|
||||
case APM_CNT_PST_CONTROL:
|
||||
/* Calling this function seems to cause
|
||||
* some kind of race condition in Linux
|
||||
* and causes a kernel oops
|
||||
*/
|
||||
break;
|
||||
case APM_CNT_ACPI_DISABLE:
|
||||
pmctrl = inl(pmbase + PM1_CNT);
|
||||
pmctrl &= ~SCI_EN;
|
||||
|
|
|
@ -20,8 +20,6 @@ void acpi_fill_fadt(acpi_fadt_t *fadt)
|
|||
fadt->smi_cmd = APM_CNT;
|
||||
fadt->acpi_enable = APM_CNT_ACPI_ENABLE;
|
||||
fadt->acpi_disable = APM_CNT_ACPI_DISABLE;
|
||||
fadt->pstate_cnt = APM_CNT_PST_CONTROL;
|
||||
fadt->cst_cnt = APM_CNT_CST_CONTROL;
|
||||
}
|
||||
|
||||
fadt->pm1a_evt_blk = pmbase;
|
||||
|
|
|
@ -16,8 +16,6 @@ void acpi_fill_fadt(acpi_fadt_t *fadt)
|
|||
fadt->smi_cmd = APM_CNT;
|
||||
fadt->acpi_enable = APM_CNT_ACPI_ENABLE;
|
||||
fadt->acpi_disable = APM_CNT_ACPI_DISABLE;
|
||||
fadt->pstate_cnt = APM_CNT_PST_CONTROL;
|
||||
fadt->cst_cnt = APM_CNT_CST_CONTROL;
|
||||
}
|
||||
|
||||
fadt->pm1a_evt_blk = pmbase;
|
||||
|
|
|
@ -16,8 +16,6 @@ void acpi_fill_fadt(acpi_fadt_t *fadt)
|
|||
fadt->smi_cmd = APM_CNT;
|
||||
fadt->acpi_enable = APM_CNT_ACPI_ENABLE;
|
||||
fadt->acpi_disable = APM_CNT_ACPI_DISABLE;
|
||||
fadt->pstate_cnt = APM_CNT_PST_CONTROL;
|
||||
fadt->cst_cnt = APM_CNT_CST_CONTROL;
|
||||
}
|
||||
|
||||
fadt->pm1a_evt_blk = pmbase;
|
||||
|
|
|
@ -277,18 +277,6 @@ static void southbridge_smi_apmc(void)
|
|||
|
||||
chipset_finalized = 1;
|
||||
break;
|
||||
case APM_CNT_CST_CONTROL:
|
||||
/* Calling this function seems to cause
|
||||
* some kind of race condition in Linux
|
||||
* and causes a kernel oops
|
||||
*/
|
||||
break;
|
||||
case APM_CNT_PST_CONTROL:
|
||||
/* Calling this function seems to cause
|
||||
* some kind of race condition in Linux
|
||||
* and causes a kernel oops
|
||||
*/
|
||||
break;
|
||||
case APM_CNT_ACPI_DISABLE:
|
||||
disable_pm1_control(SCI_EN);
|
||||
break;
|
||||
|
|
Loading…
Reference in New Issue