GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/crossgcc/buildgcc: correct clang test 

On certain versions of /bin/sh the following sequence
causes problems.
'$CC --version | grep clang &>/dev/null && ...'

The above is a bashish for 2>&1 >/dev/null. However, buildgcc
is interpeted by /bin/sh which doesn't necessarily mean bash.
On dash it's effectively forking grep off into the background
and always evaluating an empty statement to /dev/null while
unconditionally running whatever follows the &&.

Change-Id: Ie3a2ebb12226434d50a7b2a7e254c8b80ae4c46b
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: https://review.coreboot.org/14281
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Aaron Durbin 2016-04-07 16:58:10 -05:00 committed by Martin Roth
parent edff1655fe
commit b2229dc199
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
util/crossgcc/buildgcc
View File

@ -455,7 +455,7 @@ build_BINUTILS() {
build_GCC() { build_GCC() {
# Work around crazy code generator in GCC that confuses CLANG. # Work around crazy code generator in GCC that confuses CLANG.
$CC --version | grep clang &>/dev/null && $CC --version | grep clang >/dev/null 2>&1 && \
HOSTCFLAGS="$HOSTCFLAGS -fbracket-depth=1024" HOSTCFLAGS="$HOSTCFLAGS -fbracket-depth=1024"
# GCC does not honor HOSTCFLAGS at all. CFLAGS are used for # GCC does not honor HOSTCFLAGS at all. CFLAGS are used for