From b22bbe27fc9747928248eb644252129c5e630f0a Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Wed, 7 Mar 2018 15:32:16 -0700 Subject: [PATCH] Timestamps: Add option to print timestamps to debug console MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Prints the timestamp name and value to the debug console if enabled in Kconfig. Change-Id: Ie6e6a4877fefec45fb987ceae7d42de6ce768159 Signed-off-by: Martin Roth Reviewed-on: https://review.coreboot.org/25024 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin Reviewed-by: Paul Menzel Reviewed-by: Kyösti Mälkki --- src/Kconfig | 7 +++++++ src/lib/timestamp.c | 16 ++++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/src/Kconfig b/src/Kconfig index 692a5b7883..99a704dbd7 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -185,6 +185,13 @@ config COLLECT_TIMESTAMPS Make coreboot create a table of timer-ID/timer-value pairs to allow measuring time spent at different phases of the boot process. +config TIMESTAMPS_ON_CONSOLE + bool "Print the timestamp values on the console" + default n + depends on COLLECT_TIMESTAMPS + help + Print the timestamps to the debug console if enabled at level spew. + config USE_BLOBS bool "Allow use of binary-only repository" help diff --git a/src/lib/timestamp.c b/src/lib/timestamp.c index 149b8b8bbb..2ab725372b 100644 --- a/src/lib/timestamp.c +++ b/src/lib/timestamp.c @@ -154,6 +154,18 @@ static struct timestamp_table *timestamp_table_get(void) return ts_table; } +static const char *timestamp_name(enum timestamp_id id) +{ + int i; + + for (i = 0; i < ARRAY_SIZE(timestamp_ids); i++) { + if (timestamp_ids[i].id == id) + return timestamp_ids[i].name; + } + + return "Unknown timestamp ID"; +} + static void timestamp_add_table_entry(struct timestamp_table *ts_table, enum timestamp_id id, uint64_t ts_time) { @@ -166,6 +178,10 @@ static void timestamp_add_table_entry(struct timestamp_table *ts_table, tse->entry_id = id; tse->entry_stamp = ts_time - ts_table->base_time; + if (IS_ENABLED(CONFIG_TIMESTAMPS_ON_CONSOLE)) + printk(BIOS_SPEW, "Timestamp - %s: %" PRIu64 "\n", + timestamp_name(id), ts_time); + if (ts_table->num_entries == ts_table->max_entries) printk(BIOS_ERR, "ERROR: Timestamp table full\n"); }