GNUBoot/coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

cpu/intel/microcode: Enable verbose output

Browse source 
* Check if microcode is really updated.
* Enable more verbose output.

Change-Id: I534aa790c8d37b5f1603e1715635446835513a65
Signed-off-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/29864
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Reviewed-by: David Hendricks <david.hendricks@gmail.com>
This commit is contained in:
Philipp Deppenwiese 2018-11-27 14:02:15 +01:00 committed by Patrick Georgi
parent 9871b04183
commit b251c02460
1 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/cpu/intel/microcode/microcode.c
View file

@ -88,8 +88,12 @@ void intel_microcode_load_unlocked(const void *microcode_patch)
current_rev = read_microcode_rev(); current_rev = read_microcode_rev();
/* No use loading the same revision. */ /* No use loading the same revision. */
if (current_rev == m->rev) if (current_rev == m->rev) {
#if !defined(__ROMCC__)
printk(BIOS_INFO, "microcode: Update skipped, already up-to-date\n");
#endif
return; return;
}
#if ENV_RAMSTAGE #if ENV_RAMSTAGE
/*SoC specific check to update microcode*/ /*SoC specific check to update microcode*/
@ -103,11 +107,19 @@ void intel_microcode_load_unlocked(const void *microcode_patch)
msr.hi = 0; msr.hi = 0;
wrmsr(IA32_BIOS_UPDT_TRIG, msr); wrmsr(IA32_BIOS_UPDT_TRIG, msr);
current_rev = read_microcode_rev();
if (current_rev == m->rev) {
#if !defined(__ROMCC__) #if !defined(__ROMCC__)
printk(BIOS_DEBUG, "microcode: updated to revision " printk(BIOS_INFO, "microcode: updated to revision "
"0x%x date=%04x-%02x-%02x\n", read_microcode_rev(), "0x%x date=%04x-%02x-%02x\n", read_microcode_rev(),
m->date & 0xffff, (m->date >> 24) & 0xff, m->date & 0xffff, (m->date >> 24) & 0xff,
(m->date >> 16) & 0xff); (m->date >> 16) & 0xff);
#endif
return;
}
#if !defined(__ROMCC__)
printk(BIOS_INFO, "microcode: Update failed\n");
#endif #endif
} }