From b25aeb59379d04f4ad6e120e729286a341d301c8 Mon Sep 17 00:00:00 2001
From: Subrata Banik <subratabanik@google.com>
Date: Fri, 9 Dec 2022 13:19:27 +0530
Subject: [PATCH] soc/intel/meteorlake: Remove `FIXME` as SkipMpInit UPD has
 deprecated

This patch drops deprecated FSP UPD `SkipMpInit` as Intel MTL FSP
doesn't like to allow an option for boot firmware to perform CPU feature
programming being independent of FSP.

Change-Id: I6447937838ab91551d172936cbb4201ea86a614b
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/70557
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
Reviewed-by: Ivy Jian <ivy.jian@quanta.corp-partner.google.com>
---
 src/soc/intel/meteorlake/fsp_params.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/src/soc/intel/meteorlake/fsp_params.c b/src/soc/intel/meteorlake/fsp_params.c
index dc51d7bddd..4058dda287 100644
--- a/src/soc/intel/meteorlake/fsp_params.c
+++ b/src/soc/intel/meteorlake/fsp_params.c
@@ -143,11 +143,6 @@ static void fill_fsps_cpu_params(FSP_S_CONFIG *s_cfg,
 	} else {
 		/* Use coreboot native driver to perform MP init by default */
 		s_cfg->CpuMpPpi = (uintptr_t)NULL;
-		/*
-		 * FIXME: Bring back SkipMpInit UPD in MTL FSP to let coreboot perform
-		 * AP programming independently.
-		 */
-		// s_cfg->SkipMpInit = !CONFIG(USE_INTEL_FSP_MP_INIT);
 	}
 }