GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

elog: move MAX_EVENT_SIZE to commonlib/bsd/include 

Moves MAX_EVENT_SIZE to commonlib/bsd/include, and renames it
ELOG_MAX_EVENT_SIZE to give it an "scoped" name.

The moving is needed because this defined will be used from
util/cbfstool (see next CL in the chain).

BUG=b:172210863
TEST=compiles Ok

Change-Id: I86b06d257dda5b325a8478a044045b2a63fb1a84
Signed-off-by: Ricardo Quesada <ricardoq@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/57394
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
Ricardo Quesada 2021-09-03 17:01:45 -07:00 committed by Furquan Shaikh
parent 49a96a9463
commit b28a035ea0
3 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/commonlib/bsd/include/commonlib/bsd/elog.h
View File

@ -311,6 +311,9 @@ struct elog_event_extended_event {
} __packed;
/* Only the 7-LSB are used for size */
#define ELOG_MAX_EVENT_SIZE 0x7F
enum cb_err elog_verify_header(const struct elog_header *header);
const struct event_header *elog_get_next_event(const struct event_header *event);
const void *event_get_data(const struct event_header *event);

6
src/drivers/elog/elog.c
View File

@ -246,7 +246,7 @@ static size_t elog_is_event_valid(size_t offset)
if (len < (sizeof(*event) + sizeof(checksum)))
return 0;
if (len > MAX_EVENT_SIZE)
if (len > ELOG_MAX_EVENT_SIZE)
return 0;
event = elog_get_event_buffer(offset, len);
@ -613,7 +613,7 @@ int elog_clear(void)
static int elog_find_flash(void)
{
size_t total_size;
size_t reserved_space = ELOG_MIN_AVAILABLE_ENTRIES * MAX_EVENT_SIZE;
size_t reserved_space = ELOG_MIN_AVAILABLE_ENTRIES * ELOG_MAX_EVENT_SIZE;
struct region_device *rdev = &elog_state.nv_dev;
elog_debug("%s()\n", __func__);
@ -801,7 +801,7 @@ int elog_add_event_raw(u8 event_type, void *data, u8 data_size)
/* Header + Data + Checksum */
event_size = sizeof(*event) + data_size + 1;
if (event_size > MAX_EVENT_SIZE) {
if (event_size > ELOG_MAX_EVENT_SIZE) {
printk(BIOS_ERR, "ELOG: Event(%X) data size too "
"big (%d)\n", event_type, event_size);
return -1;

2
src/include/elog.h
View File

@ -6,8 +6,6 @@
#include <commonlib/bsd/elog.h>
#include <stdint.h>
#define MAX_EVENT_SIZE 0x7F
#if CONFIG(ELOG)
/* Eventlog backing storage must be initialized before calling elog_init(). */
extern int elog_init(void);