From b2d633db0711a05b617508c3594950bd513cc8e4 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Wed, 17 Feb 2021 04:47:26 +0100 Subject: [PATCH] soc/amd/common/block/data_fabric: fix data_fabric_write32 broadcast case Calling data_fabric_write32 with BROADCAST_FABRIC_ID as instance_id would have caused an infinite recursion, so call the right function data_fabric_broadcast_write32 for that case instead. Signed-off-by: Felix Held Change-Id: If7f0a80f0430e8bfb29ee510ef86c278e3a42063 Reviewed-on: https://review.coreboot.org/c/coreboot/+/50826 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons Reviewed-by: Raul Rangel --- src/soc/amd/common/block/data_fabric/data_fabric_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/soc/amd/common/block/data_fabric/data_fabric_helper.c b/src/soc/amd/common/block/data_fabric/data_fabric_helper.c index 7bbdc7f921..27fc03d58c 100644 --- a/src/soc/amd/common/block/data_fabric/data_fabric_helper.c +++ b/src/soc/amd/common/block/data_fabric/data_fabric_helper.c @@ -34,7 +34,7 @@ uint32_t data_fabric_read32(uint8_t function, uint16_t reg, uint8_t instance_id) void data_fabric_write32(uint8_t function, uint16_t reg, uint8_t instance_id, uint32_t data) { if (instance_id == BROADCAST_FABRIC_ID) { - data_fabric_write32(function, reg, BROADCAST_FABRIC_ID, data); + data_fabric_broadcast_write32(function, reg, data); return; }