GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/block/cpu: remove unused USE_COREBOOT_NATIVE_MP_INIT 

Only CONFIG_USE_INTEL_FSP_MP_INIT makes a difference whether native MP
init is used or not.

Also make USE_INTEL_FSP_MP_INIT mutually exclusive with
USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI as this option requires
coreboot to set up AP and publish PPI based on it.

Change-Id: I65b80805d3cd7b66f8c9f878d3c741b98f24288d
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33357
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Arthur Heymans 2019-06-10 11:33:40 +02:00 committed by Patrick Georgi
parent bd4ad6e630
commit b3af349284
2 changed files with 4 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Documentation/soc/intel/mp_init/mp_init.md
View File

@ -27,9 +27,9 @@ Considering these facts, there are 3 possible solutions to perform MP
initialization from coreboot + FSP space. initialization from coreboot + FSP space.
1. coreboot to perform complete MP initialization by its own. This includes 1. coreboot to perform complete MP initialization by its own. This includes
BSP and AP programming of CPU features mostly non-restricted one. Preferred BSP and AP programming of CPU features mostly non-restricted one. This is
Kconfig is USE_COREBOOT_NATIVE_MP_INIT. SoCs like SKL, KBL, APL are okay to the default configuration. Most SoCs like SKL, KBL, APL are okay to make use
make use of same Kconfig option for MP initialization. of this MP initialization method.
2. Alternatively, SoC users also can skip coreboot doing MP initialization 2. Alternatively, SoC users also can skip coreboot doing MP initialization
and make use of FSP binary to perform same task. This can be achieved by using and make use of FSP binary to perform same task. This can be achieved by using

13
src/soc/intel/common/block/cpu/Kconfig
View File

@ -51,18 +51,10 @@ config INTEL_CAR_NEM_ENHANCED
ENHANCED NEM guarantees that modified data is always ENHANCED NEM guarantees that modified data is always
kept in cache while clean data is replaced. kept in cache while clean data is replaced.
menu "Multiple Processor (MP) Initialization Options"
config USE_COREBOOT_NATIVE_MP_INIT
bool "Perform MP Initialization by coreboot"
default y if !PLATFORM_USES_FSP2_1
default n
help
This option allows user to select native coreboot option to perform
multiprocessor initialization.
config USE_INTEL_FSP_MP_INIT config USE_INTEL_FSP_MP_INIT
bool "Perform MP Initialization by FSP" bool "Perform MP Initialization by FSP"
default n default n
depends on !USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI
help help
This option allows FSP to perform multiprocessor initialization. This option allows FSP to perform multiprocessor initialization.
@ -71,9 +63,6 @@ config USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI
depends on FSP_USES_MP_SERVICES_PPI depends on FSP_USES_MP_SERVICES_PPI
default y if PLATFORM_USES_FSP2_1 default y if PLATFORM_USES_FSP2_1
default n default n
select USE_COREBOOT_NATIVE_MP_INIT
help help
This option allows FSP to make use of MP services PPI published by This option allows FSP to make use of MP services PPI published by
coreboot to perform multiprocessor initialization. coreboot to perform multiprocessor initialization.
endmenu # Multiple Processor (MP) Initialization Options