GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ec/google/chromeec: Fix keyboard_backlight call 

The EC_CMD_PWM_SET_KEYBOARD_BACKLIGHT command does not return data, so
don't specify a result buffer.

BUG=b:258126464
BRANCH=none
TEST=none

Change-Id: I5b9a0d228e187a9337498246a3b9ed8db07b95c7
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/69368
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
This commit is contained in:
Caveh Jalali 2022-11-02 03:29:32 -07:00 committed by Martin L Roth
parent a3148ca504
commit b456a96361
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/ec/google/chromeec/ec.c
View File

@ -77,20 +77,19 @@ int google_chromeec_kbbacklight(int percent)
struct ec_params_pwm_set_keyboard_backlight params = {
.percent = percent % 101,
};
struct ec_response_pwm_get_keyboard_backlight resp = {};
struct chromeec_command cmd = {
.cmd_code = EC_CMD_PWM_SET_KEYBOARD_BACKLIGHT,
.cmd_version = 0,
.cmd_data_in = &params,
.cmd_data_out = &resp,
.cmd_data_out = NULL,
.cmd_size_in = sizeof(params),
.cmd_size_out = sizeof(resp),
.cmd_size_out = 0,
.cmd_dev_index = 0,
};
google_chromeec_command(&cmd);
printk(BIOS_DEBUG, "Google Chrome set keyboard backlight: %x status (%x)\n",
resp.percent, cmd.cmd_code);
printk(BIOS_DEBUG, "Google Chrome set keyboard backlight: status (%x)\n",
cmd.cmd_code);
return cmd.cmd_code;
}