From b4a8937045daec20bdea78221f7178a71339e8a5 Mon Sep 17 00:00:00 2001 From: Keith Hui Date: Fri, 21 Jul 2023 19:26:13 -0400 Subject: [PATCH] mb/asus/p8z77-m_pro: Drop useless early init code Drop code that puts Super I/O into config mode, select serial device, then leave config mode right away having done nothing. I'll also take this chance to revise its #includes based on include-what-you-use results. Change-Id: I304fc1610740375b59121b6b8784122440795838 Signed-off-by: Keith Hui Reviewed-on: https://review.coreboot.org/c/coreboot/+/73693 Reviewed-by: Angel Pons Reviewed-by: Nico Huber Tested-by: build bot (Jenkins) --- .../p8x7x-series/variants/p8z77-m_pro/early_init.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/src/mainboard/asus/p8x7x-series/variants/p8z77-m_pro/early_init.c b/src/mainboard/asus/p8x7x-series/variants/p8z77-m_pro/early_init.c index c8d5e33cbc..cec5070a10 100644 --- a/src/mainboard/asus/p8x7x-series/variants/p8z77-m_pro/early_init.c +++ b/src/mainboard/asus/p8x7x-series/variants/p8z77-m_pro/early_init.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include -#include +#include #include #include @@ -12,7 +12,6 @@ #include #include -#define GLOBAL_DEV PNP_DEV(0x2e, 0) #define SERIAL_DEV PNP_DEV(0x2e, NCT6779D_SP2) const struct southbridge_usb_port mainboard_usb_ports[] = { @@ -35,13 +34,6 @@ const struct southbridge_usb_port mainboard_usb_ports[] = { void bootblock_mainboard_early_init(void) { - /* Setup COM/UART */ - nuvoton_pnp_enter_conf_state(GLOBAL_DEV); - - /* TODO / FIXME: Setup Multifuncion/SIO pins for COM */ - - pnp_set_logical_device(SERIAL_DEV); - nuvoton_pnp_exit_conf_state(GLOBAL_DEV); nuvoton_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE); }