From b4e94c8b0160f52cf9520521628558382063f122 Mon Sep 17 00:00:00 2001 From: Solomon Alan-Dei Date: Sun, 30 Oct 2022 03:49:59 -0600 Subject: [PATCH] util/cbfstool: fix memory leak in compress.c free the memory allocated in lz4_compress function before returning from it. Reported-by: Coverity (CID:1469433) Signed-off-by: Solomon Alan-Dei Change-Id: I8698090d519964348e51fc3b6f2023d06d81fcd5 Reviewed-on: https://review.coreboot.org/c/coreboot/+/69021 Tested-by: build bot (Jenkins) Reviewed-by: Julius Werner --- util/cbfstool/compress.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/util/cbfstool/compress.c b/util/cbfstool/compress.c index 37fac224cc..96df1a7499 100644 --- a/util/cbfstool/compress.c +++ b/util/cbfstool/compress.c @@ -23,9 +23,12 @@ static int lz4_compress(char *in, int in_len, char *out, int *out_len) if (!bounce) return -1; *out_len = LZ4F_compressFrame(bounce, worst_size, in, in_len, &prefs); - if (LZ4F_isError(*out_len) || *out_len >= in_len) + if (LZ4F_isError(*out_len) || *out_len >= in_len) { + free(bounce); return -1; + } memcpy(out, bounce, *out_len); + free(bounce); return 0; }