From b5376ff9725581e8000851e39867e0d48623a158 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Tue, 19 Oct 2021 17:44:37 +0200 Subject: [PATCH] cpu/x86/mp_init: add final new line to debug messages Since during AP startup it's not guaranteed that no AP console output will be printed between consecutive printk calls in send_sipi_to_aps, add a new line character to all printks to make sure to have the outputs from the APs on separate lines. For consistency also add a final new line character to the printk call in start_aps. Signed-off-by: Felix Held Change-Id: I3983b8a0e6b272ba5fb2a90a108d17a0c480c8b8 Reviewed-on: https://review.coreboot.org/c/coreboot/+/58454 Reviewed-by: Raul Rangel Tested-by: build bot (Jenkins) --- src/cpu/x86/mp_init.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c index 13cfd4ce3a..637adaa39e 100644 --- a/src/cpu/x86/mp_init.c +++ b/src/cpu/x86/mp_init.c @@ -429,7 +429,7 @@ static int apic_wait_timeout(int total_delay, int delay_step) static enum cb_err send_sipi_to_aps(int ap_count, atomic_t *num_aps, int sipi_vector) { if (lapic_busy()) { - printk(BIOS_DEBUG, "Waiting for ICR not to be busy..."); + printk(BIOS_DEBUG, "Waiting for ICR not to be busy...\n"); if (apic_wait_timeout(1000 /* 1 ms */, 50)) { printk(BIOS_ERR, "timed out. Aborting.\n"); return CB_ERR; @@ -439,7 +439,7 @@ static enum cb_err send_sipi_to_aps(int ap_count, atomic_t *num_aps, int sipi_ve lapic_send_ipi(LAPIC_DEST_ALLBUT | LAPIC_INT_ASSERT | LAPIC_DM_STARTUP | sipi_vector, 0); - printk(BIOS_DEBUG, "Waiting for SIPI to complete..."); + printk(BIOS_DEBUG, "Waiting for SIPI to complete...\n"); if (apic_wait_timeout(10000 /* 10 ms */, 50 /* us */)) { printk(BIOS_ERR, "timed out.\n"); return CB_ERR; @@ -472,7 +472,7 @@ static int start_aps(struct bus *cpu_bus, int ap_count, atomic_t *num_aps) printk(BIOS_DEBUG, "Starting CPUs in %s mode\n", x2apic_mode ? "x2apic" : "xapic"); if (lapic_busy()) { - printk(BIOS_DEBUG, "Waiting for ICR not to be busy..."); + printk(BIOS_DEBUG, "Waiting for ICR not to be busy...\n"); if (apic_wait_timeout(1000 /* 1 ms */, 50)) { printk(BIOS_ERR, "timed out. Aborting.\n"); return -1;