From b53bed15677e8bd97f58f7f5d847f1029ddaa41b Mon Sep 17 00:00:00 2001 From: Stefan Reinauer Date: Sat, 24 Oct 2009 13:02:14 +0000 Subject: [PATCH] Fix USB Debug Device for Intel ICH chipsets The USB EHCI controller reset is not really needed on ICH, and in fact the code bailed out there which is the most stupid thing to do. So just keep trying. Signed-off-by: Stefan Reinauer Acked-by: Carl-Daniel Hailfinger git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4836 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1 --- src/lib/usbdebug_direct.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/lib/usbdebug_direct.c b/src/lib/usbdebug_direct.c index 3125dc084d..48875dc610 100644 --- a/src/lib/usbdebug_direct.c +++ b/src/lib/usbdebug_direct.c @@ -407,11 +407,10 @@ try_next_port: cmd = readl(&ehci_regs->command); } while ((cmd & CMD_RESET) && (--loop > 0)); - if(!loop) { + if(!loop) dbgp_printk("Could not reset EHCI controller.\n"); - return; - } - dbgp_printk("EHCI controller reset successfully.\n"); + else + dbgp_printk("EHCI controller reset successfully.\n"); /* Claim ownership, but do not enable yet */ ctrl = readl(&ehci_debug->control);