GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[acpi]{include,soc/amd,southbridge/amd}: Clarify ARM_boot_arch in comments 

Change-Id: I8b209da90b5a591f62e760961c64c4c63e6ef65b
Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/62040
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jason Glenesk <jason.glenesk@gmail.com>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
Elyes Haouas 2022-02-16 14:42:19 +01:00 committed by Felix Held
parent 3a5e6f529c
commit b55ac09ce3
6 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/include/acpi/acpi.h
View File

@ -746,7 +746,7 @@ typedef struct acpi_fadt {
u32 flags;
acpi_addr_t reset_reg;
u8 reset_value;
u16 ARM_boot_arch; /* Revision 6 only, Revision 5: Must be zero */
u16 ARM_boot_arch; /* Must be zero if ACPI Revision <= 5.0 */
u8 FADT_MinorVersion; /* Must be zero if ACPI Revision <= 5.0 */
u32 x_firmware_ctl_l;
u32 x_firmware_ctl_h;

2
src/soc/amd/picasso/acpi.c
View File

@ -105,7 +105,7 @@ void acpi_fill_fadt(acpi_fadt_t *fadt)
ACPI_FADT_REMOTE_POWER_ON;
fadt->flags |= cfg->fadt_flags; /* additional board-specific flags */
fadt->ARM_boot_arch = 0; /* MUST be 0 ACPI 3.0 */
fadt->ARM_boot_arch = 0; /* Must be zero if ACPI Revision <= 5.0 */
fadt->FADT_MinorVersion = get_acpi_fadt_minor_version();
fadt->x_firmware_ctl_l = 0; /* set to 0 if firmware_ctrl is used */

2
src/soc/amd/stoneyridge/acpi.c
View File

@ -97,7 +97,7 @@ void acpi_fill_fadt(acpi_fadt_t *fadt)
ACPI_FADT_S4_RTC_VALID |
ACPI_FADT_REMOTE_POWER_ON;
fadt->ARM_boot_arch = 0; /* MUST be 0 ACPI 3.0 */
fadt->ARM_boot_arch = 0; /* Must be zero if ACPI Revision <= 5.0 */
fadt->FADT_MinorVersion = get_acpi_fadt_minor_version();
fadt->x_firmware_ctl_l = 0; /* set to 0 if firmware_ctrl is used */

2
src/southbridge/amd/agesa/hudson/fadt.c
View File

@ -62,7 +62,7 @@ void acpi_fill_fadt(acpi_fadt_t *fadt)
ACPI_FADT_S4_RTC_VALID |
ACPI_FADT_REMOTE_POWER_ON;
fadt->ARM_boot_arch = 0; /* MUST be 0 ACPI 3.0 */
fadt->ARM_boot_arch = 0; /* Must be zero if ACPI Revision <= 5.0 */
fadt->FADT_MinorVersion = get_acpi_fadt_minor_version();
fadt->x_pm1a_evt_blk.space_id = ACPI_ADDRESS_SPACE_IO;

2
src/southbridge/amd/cimx/sb800/fadt.c
View File

@ -86,7 +86,7 @@ void acpi_fill_fadt(acpi_fadt_t *fadt)
ACPI_FADT_S4_RTC_VALID |
ACPI_FADT_REMOTE_POWER_ON;
fadt->ARM_boot_arch = 0; /* MUST be 0 ACPI 3.0 */
fadt->ARM_boot_arch = 0; /* Must be zero if ACPI Revision <= 5.0 */
fadt->FADT_MinorVersion = get_acpi_fadt_minor_version();
fadt->x_pm1a_evt_blk.space_id = ACPI_ADDRESS_SPACE_IO;

2
src/southbridge/amd/pi/hudson/fadt.c
View File

@ -62,7 +62,7 @@ void acpi_fill_fadt(acpi_fadt_t *fadt)
ACPI_FADT_S4_RTC_VALID |
ACPI_FADT_REMOTE_POWER_ON;
fadt->ARM_boot_arch = 0; /* MUST be 0 ACPI 3.0 */
fadt->ARM_boot_arch = 0; /* Must be zero if ACPI Revision <= 5.0 */
fadt->FADT_MinorVersion = get_acpi_fadt_minor_version();
fadt->x_firmware_ctl_l = 0; /* set to 0 if firmware_ctrl is used */