GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

superio/fintek/f71889: Avoid .c includes 

Following the same reasoning as commit
d304331 superio/fintek/f81865f: Avoid .c includes
Clean up the early_serial #include directives in mainboard/romstage code.

Change-Id: Id8a1a2e8c87add636af1506598c2669d72dc3238
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/5437
Tested-by: build bot (Jenkins)
Reviewed-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
This commit is contained in:
Edward O'Callaghan 2014-03-31 15:14:14 +11:00 committed by Alexandru Gagniuc
parent 880e5248dc
commit b5a49ad9d7
4 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/superio/fintek/f71889/Makefile.inc
View File

@ -18,5 +18,5 @@
## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
## ##
romstage-$(CONFIG_SUPERIO_FINTEK_F71889) += early_serial.c
ramstage-$(CONFIG_SUPERIO_FINTEK_F71889) += superio.c ramstage-$(CONFIG_SUPERIO_FINTEK_F71889) += superio.c

2
src/superio/fintek/f71889/chip.h
View File

@ -29,4 +29,4 @@ struct superio_fintek_f71889_config {
struct pc_keyboard keyboard; struct pc_keyboard keyboard;
}; };
#endif #endif /* SUPERIO_FINTEK_F71889_CHIP_H */

4
src/superio/fintek/f71889/early_serial.c
View File

@ -18,8 +18,8 @@
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/ */
#include <stdint.h>
#include <arch/io.h> #include <arch/io.h>
#include <device/pnp.h>
#include "f71889.h" #include "f71889.h"
static void pnp_enter_conf_state(device_t dev) static void pnp_enter_conf_state(device_t dev)
@ -35,7 +35,7 @@ static void pnp_exit_conf_state(device_t dev)
outb(0xaa, port); outb(0xaa, port);
} }
static void f71889_enable_serial(device_t dev, u16 iobase) void f71889_enable_serial(device_t dev, u16 iobase)
{ {
pnp_enter_conf_state(dev); pnp_enter_conf_state(dev);
pnp_set_logical_device(dev); pnp_set_logical_device(dev);

4
src/superio/fintek/f71889/f71889.h
View File

@ -34,4 +34,6 @@
#define F71889_PME 0x0a /* Power Management Events (PME) and ACPI */ #define F71889_PME 0x0a /* Power Management Events (PME) and ACPI */
#define F71889_VREF 0x0b /* Vref */ #define F71889_VREF 0x0b /* Vref */
#endif void f71889_enable_serial(device_t dev, u16 iobase);
#endif /* SUPERIO_FINTEK_F71889_F71889_H */