From b5ff9b9f3f6387df800ceec2dd0daee1d02c8939 Mon Sep 17 00:00:00 2001 From: Karthikeyan Ramasubramanian Date: Mon, 25 Jul 2022 13:35:14 -0600 Subject: [PATCH] soc/amd/sabrina: Do not pass SHA operation mode Currently only SHA_GENERIC is used and does not need to be passed. BUG=b:217414563 TEST=Build and boot to OS in Skyrim with PSP and x86 verstage. Change-Id: Id705b1361fffaf940c51515e7f77d7fb0677fc4a Signed-off-by: Karthikeyan Ramasubramanian Reviewed-on: https://review.coreboot.org/c/coreboot/+/66133 Tested-by: build bot (Jenkins) Reviewed-by: Raul Rangel --- src/soc/amd/sabrina/psp_verstage/svc.c | 2 +- src/soc/amd/sabrina/psp_verstage/svc.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/soc/amd/sabrina/psp_verstage/svc.c b/src/soc/amd/sabrina/psp_verstage/svc.c index 370481c018..021b344a57 100644 --- a/src/soc/amd/sabrina/psp_verstage/svc.c +++ b/src/soc/amd/sabrina/psp_verstage/svc.c @@ -166,8 +166,8 @@ uint32_t svc_crypto_sha(struct sha_generic_data *sha_op, enum sha_operation_mode uint32_t retval = 0; struct cmd_param_sha param = { .ptr_sha_op = sha_op, - .sha_mode = sha_mode, }; + assert(sha_mode == SHA_GENERIC); SVC_CALL2(SVC_VERSTAGE_CMD, CMD_SHA, (void *)¶m, retval); return retval; } diff --git a/src/soc/amd/sabrina/psp_verstage/svc.h b/src/soc/amd/sabrina/psp_verstage/svc.h index 40dbc3e00d..c73ac3d61f 100644 --- a/src/soc/amd/sabrina/psp_verstage/svc.h +++ b/src/soc/amd/sabrina/psp_verstage/svc.h @@ -61,7 +61,6 @@ struct cmd_param_sha { struct sha_generic_data *ptr_sha_op; - enum sha_operation_mode sha_mode; }; struct cmd_param_debug {